Skip to content

Commit c510fe7

Browse files
ZheyuMabirkelund
authored andcommitted
hw/nvme: fix memory leak in nvme_dsm
The allocated memory to hold LBA ranges leaks in the nvme_dsm function. This happens because the allocated memory for iocb->range is not freed in all error handling paths. Fix this by adding a free to ensure that the allocated memory is properly freed. ASAN log: ==3075137==ERROR: LeakSanitizer: detected memory leaks Direct leak of 480 byte(s) in 6 object(s) allocated from: #0 0x55f1f8a0eddd in malloc llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3 #1 0x7f531e0f6738 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5e738) qemu#2 0x55f1faf1f091 in blk_aio_get block/block-backend.c:2583:12 qemu#3 0x55f1f945c74b in nvme_dsm hw/nvme/ctrl.c:2609:30 qemu#4 0x55f1f945831b in nvme_io_cmd hw/nvme/ctrl.c:4470:16 qemu#5 0x55f1f94561b7 in nvme_process_sq hw/nvme/ctrl.c:7039:29 Cc: [email protected] Fixes: d7d1474 ("hw/nvme: reimplement dsm to allow cancellation") Signed-off-by: Zheyu Ma <[email protected]> Reviewed-by: Klaus Jensen <[email protected]> Signed-off-by: Klaus Jensen <[email protected]>
1 parent a7ddb48 commit c510fe7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

hw/nvme/ctrl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2591,6 +2591,7 @@ static void nvme_dsm_cb(void *opaque, int ret)
25912591
done:
25922592
iocb->aiocb = NULL;
25932593
iocb->common.cb(iocb->common.opaque, iocb->ret);
2594+
g_free(iocb->range);
25942595
qemu_aio_unref(iocb);
25952596
}
25962597

0 commit comments

Comments
 (0)