Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y issue for placeholders #3519

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 27, 2024

Proposed changes

closes #2587 & db-ui/design-feedback#134

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-opacity-placeholder-a11y-issue

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Nov 27, 2024
mfranzke
mfranzke previously approved these changes Nov 27, 2024
@mfranzke mfranzke self-assigned this Nov 27, 2024
@mfranzke mfranzke added this to the v0.6.0 milestone Nov 27, 2024
@nmerget nmerget enabled auto-merge (squash) November 27, 2024 14:41
@nmerget nmerget merged commit 168bfec into main Nov 27, 2024
69 checks passed
@nmerget nmerget deleted the fix-opacity-placeholder-a11y-issue branch November 27, 2024 19:46
@mfranzke mfranzke added 🐛bug Something isn't working 👂accessibility Accessibility issues/improvements labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👂accessibility Accessibility issues/improvements 🐛bug Something isn't working 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Components: Placeholder accessibility issue
2 participants