Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Warnings about vertical whitespace for email sents with a long subject #139

Open
dboehmer opened this issue Jan 4, 2021 · 2 comments
Open
Assignees

Comments

@dboehmer
Copy link
Owner

dboehmer commented Jan 4, 2021

For an example see https://travis-ci.org/github/dboehmer/coocook/jobs/752858214

t/change_password.t ........... 2/53 replaced vertical whitespace in Subject header with space; this will become fatal in a future version at /home/travis/perl5/perlbrew/perls/5.30.3/lib/site_perl/5.30.3/Catalyst/View/Email.pm line 396.
replaced vertical whitespace in Subject header with space; this will become fatal in a future version at /home/travis/perl5/perlbrew/perls/5.30.3/lib/site_perl/5.30.3/Catalyst/View/Email.pm line 396.

@moseschmiedel already inspected this and filed dhoss/catalyst-view-email#15

Looking at dhoss/catalyst-view-email#10 it seems the current maintainers will probably not take care of this.

@dboehmer
Copy link
Owner Author

dboehmer commented Jan 5, 2021

A minimal test for this that runs faster than the test suite:

use strict;
use warnings;

use lib 't/lib';
use Test::Coocook;
use Test::Most;

my $t = Test::Coocook->new;

$t->get_ok('/settings');
$t->login_ok( 'john_doe', 'P@ssw0rd' );
$t->submit_form_ok( { with_fields => { new_email => '[email protected]' } } );
note $t->emails->[0]{email}->as_string;
done_testing;

@moseschmiedel moseschmiedel self-assigned this Jan 5, 2021
@dboehmer
Copy link
Owner Author

That is not exactly what we wanted:

image

@dboehmer dboehmer reopened this Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants