Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify role of the Derived From field #158

Open
white-gecko opened this issue Jan 4, 2024 · 2 comments
Open

Clarify role of the Derived From field #158

white-gecko opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@white-gecko
Copy link
Contributor

The "Derived From" field in the input form of the Publish Wizard is a multi line filed without any specific validation.

image

This caused the impression for me that it should hold an unstructured description of the provenance of the dataset. However in the generated JSON data it is represented as in one field wasDerivedFrom which is then converted to one IRI <https://metadata.coypu.org/dataset/wikidata-distribution https://query.wikidata.org/> which is not accepted by gstore.

[
  {
    "@type": [
      "Version",
      "Dataset"
    ],
    "@id": "https://databus.coypu.org/narndt/coypu/countries/2023-09-18T122214Z",
    "hasVersion": "2023-09-18T122214Z",
    "title": "Countries",
    "abstract": "Countries 2023-09-18T12:22:14Z",
    "description": "Countries 2023-09-18T12:22:14Z",
    "license": "https://dalicc.net/licenselibrary/Cc010Universal",
    "attribution": null,
    "wasDerivedFrom": "https://metadata.coypu.org/dataset/wikidata-distribution\nhttps://query.wikidata.org/",
    "distribution": [
      {
        "@type": "Part",
        "formatExtension": "ttl",
        "compression": "none",
        "downloadURL": "https://databus.coypu.org/dav/narndt/coypu/countries/2023-09-18T122214Z/countries_freqency=static.ttl",
        "dcv:frequency": "static"
      }
    ]
  }
]

My expectations

The input form should get some kind of description which data shall be inserted in this filed and the data should be validated by the databus before it is sent to the store.

@manonthegithub
Copy link
Collaborator

I see two problems here:

  • the interface allows to enter something except IRI
  • the API passes through the wrong input (the context specifies that it must be @id, but there is no check the the actual data is an id)

@holycrab13
Copy link
Contributor

I will change the interface and add a server-side check before saving to gstore. I will try to also allow adding multiple derivedFrom triples via the UI

@holycrab13 holycrab13 self-assigned this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants