Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser filters on group page not working correctly #161

Open
manonthegithub opened this issue Jan 11, 2024 · 8 comments
Open

File browser filters on group page not working correctly #161

manonthegithub opened this issue Jan 11, 2024 · 8 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@manonthegithub
Copy link
Collaborator

image

On the screenshot geo-coordinates filter didn't work

@manonthegithub manonthegithub added the bug Something isn't working label Jan 11, 2024
@m1ci
Copy link
Collaborator

m1ci commented Jan 11, 2024

Screenshot 2024-01-11 at 10 19 41

@m1ci
Copy link
Collaborator

m1ci commented Jan 12, 2024

also, why the artifacts are hard-coded?

2022.12.01

https://databus.dbpedia.org/marvin/generic

en

PREFIX rdfs:   <http://www.w3.org/2000/01/rdf-schema#>
PREFIX rdf:    <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX dcat:   <http://www.w3.org/ns/dcat#>
PREFIX dct:    <http://purl.org/dc/terms/>
PREFIX dcv: <https://dataid.dbpedia.org/databus-cv#>
PREFIX databus: <https://dataid.dbpedia.org/databus#>
SELECT ?file WHERE
{
	GRAPH ?g
	{
		?dataset databus:group <https://databus.dbpedia.org/marvin/generic> .
		{ ?distribution <https://dataid.dbpedia.org/databus-cv#lang> 'en' . }
		{ ?distribution <http://purl.org/dc/terms/hasVersion> '2022.12.01' . }
		{
			?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/anchor-text> .
		}
		UNION
		{
			?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/article-templates> .
		}
		UNION
		{
			?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/categories> .
		}
		UNION
		{
			?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/citations> .
		}
		UNION
		{
			?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/commons-sameas-links> .
		}
		UNION
		{
			?dataset databus:artifact <https://databus.dbpedia.org/marvin/generic/disambiguations> .
		}
		?dataset dcat:distribution ?distribution .
		?distribution databus:file ?file .
	}
}

@manonthegithub
Copy link
Collaborator Author

manonthegithub commented Jan 12, 2024

@m1ci

also, why the artifacts are hard-coded?

2022.12.01

https://databus.dbpedia.org/marvin/generic

en

I don't think they are :). The query is generated just like this with artefact names as consts...

@m1ci
Copy link
Collaborator

m1ci commented Jan 12, 2024

there are many more artifacts and the question is why they are not in the query?

@holycrab13 holycrab13 changed the title Filters are often not working... File browser filters on group page not working correctly Jan 17, 2024
@holycrab13
Copy link
Contributor

The query generator was being passed the wrong array of artifacts (the currently displayed ones instead of all)
The first issue still persists, the query generator is not working correctly here.

there's no hard-coded SPARQL, the queries are generated.

@holycrab13
Copy link
Contributor

Working on a fix

@holycrab13 holycrab13 self-assigned this Jan 18, 2024
@JJ-Author JJ-Author added duplicate This issue or pull request already exists and removed bug Something isn't working labels Jan 24, 2024
@JJ-Author
Copy link
Collaborator

what @manonthegithub wrote seems duplicate to this here #124
but @m1ci thing might be something different. but I am not sure. so maybe rename/clarify/clean up the issue if its not already fixed.

@holycrab13
Copy link
Contributor

possible fix deployed on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants