Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Notifications #4

Closed
leandrok opened this issue Sep 24, 2024 · 6 comments · Fixed by #7
Closed

Slack Notifications #4

leandrok opened this issue Sep 24, 2024 · 6 comments · Fixed by #7

Comments

@leandrok
Copy link

Hello, congratulations for this great service
Can you add the ability of sending Slack notifications please?

@camaeel
Copy link
Collaborator

camaeel commented Sep 24, 2024

@leandrok
Thanks.

Although we don't need such notifications internally it may make sense to have notifications.
I'm hesitating if those should go to "slack-compatible" http webhook or some notification service like SNS. SNS might be more robust than simple http request, on the other hand SNS will be cloud provider specific and node-undertaker is designed to be able to handle nodes running using other infrastructure providers (for now only AWS is implemented).

As a quick workaround and temporary solution, you can try monitoring events that are created after every action taken by node-undertaker. Kube-state-metrics or some event exporters can be helpful.

@leandrok
Copy link
Author

Thanks for your feedback. Yes, SNS can be a good option so users have the flexibility of sending the alerts to different targets (email, Slack, webhook) through SNS.. I'll check the metrics export approach. Thanks.

@camaeel
Copy link
Collaborator

camaeel commented Sep 24, 2024

Another idea could be to utilize metrics exposed by the application. It exposes standard prometheus format metrics, but they are not yet documented.
I created separate ticket to track this issue: #5

@leandrok
Copy link
Author

Perfect thanks!

@camaeel
Copy link
Collaborator

camaeel commented Oct 4, 2024

I updated information about metric that exports node statuses observed.

@camaeel
Copy link
Collaborator

camaeel commented Dec 16, 2024

Released with v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants