Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

Discoverability #5

Closed
benmccann opened this issue Sep 10, 2023 · 10 comments
Closed

Discoverability #5

benmccann opened this issue Sep 10, 2023 · 10 comments

Comments

@benmccann
Copy link

You might consider listing this component on sveltesociety.dev. Or perhaps joining efforts with the other SvelteKit adapter for Deno that already exists

https://sveltesociety.dev/components#component-svelte-adapter-deno

@dbushell
Copy link
Owner

Thanks for the suggestion!

Originally this was going to be a PR to the existing adapter. I added my notes to the related Deno Deploy issue. My "fix" ended up being a complete rewrite so I published it here as a working example.

I'm hesitant to promote this adapter because ideally there would only be one (the original). But it seems like neither myself nor the original author have any time now.

I'd rather be coding SvelteKit websites but I'm stuck on WordPress projects right now 😞

@jpaquim
Copy link

jpaquim commented Oct 30, 2023

@dbushell hey, I was just thinking of writing you concerning merging projects, I think it's redundant to have both and I really haven't had the time to look after svelte-adapter-deno lately, I'm not working with Deno presently. Let me know what you think, I'm happy with either upstreaming your code into my repo, or otherwise transferring the npm package name and you can rename the repo if it makes sense, whatever works for you 🙂

@dbushell
Copy link
Owner

dbushell commented Nov 1, 2023

@jpaquim I'm in a similar position I'm not doing much Svelte Kit lately. So I may not be able to maintain anything going forward!

I think it's fine though to leave both repos as they are for now. There is value in your version using Rollup which the official adapters use. Maybe someone else will come along and make a unified version.

Anyway, thanks for the comment. I'll give it more thought if I start working with Svelte Kit again.

@Malix-Labs
Copy link

Malix-Labs commented Oct 24, 2024

Repost from #16 (duplicate)

Publishing Link

https://www.sveltesociety.dev/help/submitting?type=package

Manifest Proposal

{
	"title": "sveltekit-adapter-deno",
	"repository": "https://github.com/dbushell/sveltekit-adapter-deno",
	"description": "🦕 SvelteKit Adapter for Deno and Deno Deploy",
	"npm": "sveltekit-adapter-deno",
	"categories": [
		"sveltekit-adapters"
	]
}

@HighPriest
Copy link

This is great!
What about publishing it to JSR aswell?

@Malix-Labs
Copy link

Malix-Labs commented Oct 24, 2024

Yep, would definitely be better, see #21

Also, replacing

npm install --save-dev sveltekit-adapter-deno

with

deno add npm:sveltekit-adapter-deno

wouldn't hurt

You know what I'm gonna PR that right away

Update: #20

@benmccann
Copy link
Author

I think these days the official adapter-node should work?

@HighPriest
Copy link

HighPriest commented Oct 24, 2024

It should, but it is not going to be comfortable for people who want to see marriage of SvelteKit & Deno 😬

@Malix-Labs
Copy link

the official adapter-node should work?

It does, but it is a compatibility layer instead of a better rewrite

@dbushell
Copy link
Owner

Honestly I'd suggest using the official node adapter if it works. The Deno > Node compatibility layer shouldn't be a concern. From what I understand it's largely a thin layer mapping APIs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants