From c4f0fad2909f53d54d988643397e33e6f51d6fc1 Mon Sep 17 00:00:00 2001 From: Shivam Malhotra Date: Mon, 13 Jan 2025 22:40:59 +0100 Subject: [PATCH 1/2] Test commit --- gradle/libs.versions.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index cb4cc6e18dc..bd7efcf5846 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -61,7 +61,7 @@ mindrot = "0.4" nidi = "0.18.1" oshi = "5.8.3" pac4j = "5.7.0" -parquet = "1.14.3" +parquet = "1.15.0" picocli = "4.7.6" postgresql = "42.7.4" protobuf = "3.25.4" From 0820f85616cf8c63f0a271d2da5ba3e2be748497 Mon Sep 17 00:00:00 2001 From: Shivam Malhotra Date: Tue, 14 Jan 2025 19:42:05 +0100 Subject: [PATCH 2/2] Updated the failing tests --- .../java/io/deephaven/parquet/table/TestParquetTools.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java b/extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java index ddb1894d25a..f284fea0a84 100644 --- a/extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java +++ b/extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java @@ -644,7 +644,9 @@ public void testWriteParquetFieldIds() throws NoSuchAlgorithmException, IOExcept // This is somewhat fragile, but has been manually verified to contain the field_ids that we expect. // We may want to consider more explicit tests that verify our writing logic is consistent, as it would be good // to know whenever serialization changes in any way. - assertEquals("2ea68b0ddaeb432e9c2721f15460b6c42449a479c1960e836f6ebe3b14f33dc1", sha256sum(file.toPath())); + // For example, this test can fail when we upgrade the parquet version simply because the "createdBy" field + // captures this version. + assertEquals("208abbee39fc8034322d10032d07098ad7766c8fbf17c9e74e58ccd1ce278037", sha256sum(file.toPath())); // TODO(deephaven-core#6128): Allow Parquet column access by field_id // This test is a bit circular; but assuming we trust our reading code, we should have relative confidence that