Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @deephaven/components as a dependency for @deephaven/jsapi-bootstrap #2193

Open
mattrunyon opened this issue Aug 15, 2024 · 0 comments
Open

Remove @deephaven/components as a dependency for @deephaven/jsapi-bootstrap #2193

mattrunyon opened this issue Aug 15, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@mattrunyon
Copy link
Collaborator

As a user, I want to be able to use the @deephaven/jsapi-bootstrap package without it also providing loading overlays and a failure modal in my app.

We shouldn't have a dependency on @deephaven/components from @deephaven/jsapi-bootstrap since it should just load and provide the api/client via React contexts. The loading should be part of @deephaven/app-utils.
@mattrunyon mattrunyon added enhancement New feature or request triage Issue requires triage labels Aug 15, 2024
@vbabich vbabich added this to the Backlog milestone Aug 20, 2024
@vbabich vbabich removed the triage Issue requires triage label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@vbabich @mattrunyon