Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluation pipeline should return all element types #242

Merged
merged 4 commits into from
Dec 9, 2024
Merged

fix: evaluation pipeline should return all element types #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58a9182
fix: evaluation pipeline should return all element types
mhordynski Dec 9, 2024
12f9db7
fix imports
mhordynski Dec 9, 2024
ba86a09
fix type
mhordynski Dec 9, 2024
90d36d7
add changelog
mhordynski Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/ragbits-evaluate/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Changed

- document search evaluation now returns all Element types, rather than only TextElements (#241).

## 0.5.0 (2024-12-05)

### Changed
Expand Down
3 changes: 1 addition & 2 deletions packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from ragbits.document_search import DocumentSearch
from ragbits.document_search.documents.document import DocumentMeta
from ragbits.document_search.documents.element import TextElement
from ragbits.document_search.documents.sources import HuggingFaceSource
from ragbits.evaluate.pipelines.base import EvaluationPipeline, EvaluationResult

Expand Down Expand Up @@ -50,7 +49,7 @@ async def __call__(self, data: dict) -> DocumentSearchResult:
The evaluation result.
"""
elements = await self.document_search.search(data["question"])
predicted_passages = [element.content for element in elements if isinstance(element, TextElement)]
predicted_passages = [element.text_representation or "" for element in elements]
return DocumentSearchResult(
question=data["question"],
reference_passages=data["passages"],
Expand Down
Loading