New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(common): coverage for all curves #135

Open

sebasti810 opened this issue Oct 4, 2024 · 0 comments

Labels

good first issue testing

Contributor

sebasti810 commented Oct 4, 2024

We currently have two curve implementations (secp256k1 and Ed25519), but our tests only cover one, depending on the feature flag:

#[cfg(not(feature = "secp256k1"))]
pub fn create_mock_signing_key() -> SigningKey {
    SigningKey::Ed25519(Ed25519SigningKey::generate(&mut OsRng))
}

we should modify test_utils to run tests for both curve variants unconditionally, rather than relying on a feature

distractedm1nd changed the title ~~Test Coverage for Multiple Curve Implementations~~ tests(common): coverage for all curves

distractedm1nd added good first issue testing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment