Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_modified_time? #114

Open
euven opened this issue Oct 3, 2024 · 1 comment · May be fixed by #115
Open

Implement get_modified_time? #114

euven opened this issue Oct 3, 2024 · 1 comment · May be fixed by #115

Comments

@euven
Copy link

euven commented Oct 3, 2024

When running manage.py collectstatic, I notice that the remote files in Swift, is deleted and re-uploaded every time, even if the files are identical.

Is there any reason you haven't implemented get_modified_time: https://github.com/django/django/blob/stable/5.1.x/django/core/files/storage/base.py#L199 ?

Thanks for this module, it works well! :)
@euven euven linked a pull request Oct 3, 2024 that will close this issue
Open
@euven
Copy link
Author

euven commented Oct 3, 2024

Hey @dennisv I noticed that the modification time was actually implemented, but that the method name for this has become out of date with what the newer Django File API expects. Nevertheless, see the related pull request ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

amend modified time method to support new django file api euven/django-storage-swift
1 participant
@euven