Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use @deno/emit to bundle deps for GitHub Actions #317

Merged
merged 9 commits into from
Jul 23, 2024
Merged

chore: use @deno/emit to bundle deps for GitHub Actions #317

merged 9 commits into from
Jul 23, 2024

Conversation

magurotuna
Copy link
Member

@magurotuna magurotuna commented Jul 23, 2024 •
edited
Loading

  • Add tools/bundle.ts that invokes @deno/emit to bundle the script for GitHub Actions
  • Refresh action/deps.js by running tools/bundle.ts
  • Bump @deno/shim-deno to 0.19.2 to enable Deno.osRelease()
  • Run npm install to make @deno/[email protected] available

Resolves #315

@magurotuna magurotuna changed the title Use @deno/emit to bundle deps for GitHub Actions chore: use @deno/emit to bundle deps for GitHub Actions Jul 23, 2024
@magurotuna magurotuna requested a review from arnauorriols July 23, 2024 06:36
arnauorriols
arnauorriols approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@arnauorriols arnauorriols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magurotuna magurotuna merged commit acb2ba3 into denoland:main Jul 23, 2024
11 checks passed
@magurotuna magurotuna mentioned this pull request Jul 23, 2024
Merged
@magurotuna magurotuna deleted the deno-emit branch July 24, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnauorriols arnauorriols arnauorriols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move away from deprecated deno bundle when generating JS files for GitHub Actions
2 participants
@magurotuna @arnauorriols