Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max CFI: Comment-out Service-associated Github Workflows or Test Runs within VRO #4147

Closed
dfitchett opened this issue Feb 25, 2025 · 0 comments · Fixed by #4166
Closed

Max CFI: Comment-out Service-associated Github Workflows or Test Runs within VRO #4147

dfitchett opened this issue Feb 25, 2025 · 0 comments · Fixed by #4166
Assignees
@dfitchett
Labels
disability-max-ratings-api Ticket related to the disability-max-ratings-api repo

Comments

@dfitchett
Copy link
Contributor

Description

Specific GitHub workflows or test runs within the abd-vro repository are associated with shut down services. These workflows and tests should be commented out to avoid unnecessary execution and dependabot/security updates.

Acceptance Criteria

  1. Code Changes

    • Identify all GitHub workflows or test runs related to the disabled or inactive services.
    • Comment out the code for these workflows/tests to prevent their execution.

  2. Documentation

    • Add clear comments above the commented-out code explaining:
      • Why the workflows/tests are being disabled.
      • Any conditions required to re-enable the workflows/tests in the future.
@dfitchett dfitchett added the blocked a label for items that need unblocking label Feb 25, 2025
@meganhicks meganhicks mentioned this issue Feb 25, 2025
Open
@dfitchett dfitchett added disability-max-ratings-api Ticket related to the disability-max-ratings-api repo and removed blocked a label for items that need unblocking labels Mar 3, 2025
@dfitchett dfitchett assigned dfitchett and unassigned dfitchett Mar 3, 2025
@dfitchett dfitchett mentioned this issue Mar 3, 2025
Merged
@dfitchett dfitchett linked a pull request Mar 3, 2025 that will close this issue
Comment out workflows, actions, docker compose elements, and gradle elements for max-cfi and cc-app #4166
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfitchett dfitchett

Labels
disability-max-ratings-api Ticket related to the disability-max-ratings-api repo
Projects
None yet
Milestone
No milestone
1 participant
@dfitchett