Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change text of va-button using continue #3724

Open
2 of 6 tasks
rhasselle-oddball opened this issue Jan 23, 2025 · 4 comments · May be fixed by department-of-veterans-affairs/component-library#1485
Open
2 of 6 tasks

Cannot change text of va-button using continue #3724

rhasselle-oddball opened this issue Jan 23, 2025 · 4 comments · May be fixed by department-of-veterans-affairs/component-library#1485
Assignees
@jamigibbs
Labels
DST-prioritized DST PO prioritized item enhancement New feature or request platform-design-system-team va-button DS Buttons

Comments

@rhasselle-oddball
Copy link

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

Related to:

What happened

I want to do this:

<VaButton
  continue
  submit="prevent"
  text="Save and continue"
/>

However you cannot override the text when using continue. We need to use continue so that we have the arrows icon next to the text.

What I expected to happen

Should be able to change the text of va-button when continue is set

Reproducing

  • CSS Library version:
  • Device: (e.g. iPhone 8, Macbook)
  • Browser: (e.g. Firefox, IE 11)

Steps to reproduce:

  1. Try using continue with text and notice text does not take effect for va-button

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details
@caw310 caw310 added the va-button DS Buttons label Jan 23, 2025
@micahchiang
Copy link
Contributor

Thanks for submitting this @rhasselle-oddball! I'm going to re-label this as a feature request, since this has been the intended functionality of the continue prop for a while. Either way, we'll get this sized and prioritized in our backlog.

@micahchiang micahchiang added enhancement New feature or request and removed bug Something isn't working labels Jan 23, 2025
@humancompanion-usds
Copy link
Collaborator

@caw310 and @micahchiang - This is blocking some work in the list and loop pattern and I'd like to get this fix into an upcoming sprint. Can you slot it in sometime soon? Thanks!

@caw310 caw310 added the DST-prioritized DST PO prioritized item label Jan 31, 2025
@caw310
Copy link
Contributor

caw310 commented Feb 3, 2025 •
edited by Andrew565
Loading

Provide your estimate of 1, 2, 3, 5, 8 or 13
@Andrew565 - 3
@ataker - 2
@harshil1793 - 2
@it-harrison - 2
@jamigibbs - 1
@micahchiang - 3
@powellkerry - 3
@rmessina1010 - 3, but with design discussion
@rsmithadhoc - 1

@jamigibbs jamigibbs self-assigned this Feb 5, 2025
@micahchiang
Copy link
Contributor

button text for continue is hard coded here.

The back and continue props also conditionally render the icons used for back and continue buttons.

@jamigibbs jamigibbs linked a pull request Feb 6, 2025 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamigibbs jamigibbs

Labels
DST-prioritized DST PO prioritized item enhancement New feature or request platform-design-system-team va-button DS Buttons
Projects
None yet
Milestone
No milestone
5 participants
@jamigibbs @micahchiang @humancompanion-usds @caw310 @rhasselle-oddball