VACMS-12082 Fix service accordions headers #2401
Merged
+53
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/main/VACMS-12082-service-accordions
|
@thejordanwood We are fixing the heading structure, is it ok if use the DS default h4 sizes rather than keeping the existing H3 size? This would change the visual but not by much: Current visual display with H3 headings and sizes: New display with H4s and sizes: |
|
@laflannery Yes, that looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust hard-coded service accordion interior headings to be
<h4>instead of<h3>.Related issue(s)
department-of-veterans-affairs/va.gov-cms#12082
Testing done
Tested at http://localhost:3002/boston-health-care/health-services/, http://localhost:3002/lovell-federal-health-care-va/health-services/ and http://localhost:3002/lovell-federal-health-care-tricare/health-services/.
Screenshots
/boston-health-care/health-services/
/lovell-federal-health-care-va/health-services/
/lovell-federal-health-care-tricare/health-services/
What areas of the site does it impact?
VAMC Health Services pages