Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Time To Sent #2169

Open
5 tasks
k-macmillan opened this issue Dec 6, 2024 · 0 comments
Open
5 tasks

Log Time To Sent #2169

k-macmillan opened this issue Dec 6, 2024 · 0 comments

Comments

@k-macmillan
Copy link
Member

User Story - Business Need

When we have sent a request to a provider, log the time from created until we have an initial response from the provider (Twilio, Pinpoint, SES, etc.). This is applicable to SMS and email requests.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As VA Notify
I want to track how long it takes from request received until we have sent it to a provider
So that we can start to understand more fine-grained performance

Additional Info and Resources

Be careful if log_notification_total_time is reused. Loosening the guard statement has risks for improper reporting. It may be best to just make a new method, only called for pre-provider total time logging.

Acceptance Criteria

  • Create a timestamp when the request first enters the post_notifications method
  • Pass that along to the created/persisted notification so the created_at can be set with it
  • Just prior to calling the provider, log the total time
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Just a logging thing. Shouldn't need more than a validation it is logging for each use case (Twilio, Pinpoint, SES).

Potential Dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants