Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Sent to Celery Service with Retry #2172

Open
7 tasks
k-macmillan opened this issue Dec 9, 2024 · 0 comments
Open
7 tasks

Push Sent to Celery Service with Retry #2172

k-macmillan opened this issue Dec 9, 2024 · 0 comments

Comments

@k-macmillan
Copy link
Member

User Story - Business Need

We are attempting to clean up all errors that are not really errors. One of the big ones is returning a 502 if VEText takes too long to respond to a push request.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA Notify dev
I want logs to only show an error if there is a problem
So that we can be alerted to unexpected behavior

Additional Info and Resources

The method that accepts push requests is: send_push_notification.

See API deliver_email and deliver_sms methods for retry functionality.

Acceptance Criteria

  • Push and Broadcast are sent to the send-email-tasks Celery queue
  • Celery method is called deliver_push to keep things consistent
  • AutoRetryFor functionality is setup
  • Any non-2xx response from VEText is retried
  • We never return a non-2xx
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Would probably need a new branch to give it a fake VEText URL so it forces the retry, then we can deploy main to verify it processes the request.

Potential Dependencies

Out of Scope

Creating a new queue. We are going to funnel push to the email queue. Excessive queues slow down Celery's ability to process the busier queues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants