You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are attempting to clean up all errors that are not really errors. One of the big ones is returning a 502 if VEText takes too long to respond to a push request.
Ticket is understood, and QA has been contacted (if the ticket has a QA label).
User Story(ies)
As a VA Notify dev I want logs to only show an error if there is a problem So that we can be alerted to unexpected behavior
Additional Info and Resources
The method that accepts push requests is: send_push_notification.
See API deliver_email and deliver_sms methods for retry functionality.
Acceptance Criteria
Push and Broadcast are sent to the send-email-tasks Celery queue
Celery method is called deliver_push to keep things consistent
AutoRetryFor functionality is setup
Any non-2xx response from VEText is retried
We never return a non-2xx
This work is added to the sprint review slide deck (key win bullet point and demo slide)
QA Considerations
Would probably need a new branch to give it a fake VEText URL so it forces the retry, then we can deploy main to verify it processes the request.
Potential Dependencies
Out of Scope
Creating a new queue. We are going to funnel push to the email queue. Excessive queues slow down Celery's ability to process the busier queues.
The text was updated successfully, but these errors were encountered:
User Story - Business Need
We are attempting to clean up all errors that are not really errors. One of the big ones is returning a 502 if VEText takes too long to respond to a push request.
User Story(ies)
As a VA Notify dev
I want logs to only show an error if there is a problem
So that we can be alerted to unexpected behavior
Additional Info and Resources
The method that accepts push requests is:
send_push_notification
.See API
deliver_email
anddeliver_sms
methods for retry functionality.Acceptance Criteria
send-email-tasks
Celery queuedeliver_push
to keep things consistentAutoRetryFor
functionality is setupQA Considerations
Would probably need a new branch to give it a fake VEText URL so it forces the retry, then we can deploy main to verify it processes the request.
Potential Dependencies
Out of Scope
Creating a new queue. We are going to funnel push to the email queue. Excessive queues slow down Celery's ability to process the busier queues.
The text was updated successfully, but these errors were encountered: