Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Technical-Failure from Stats #2191

Open
3 tasks
EvanParish opened this issue Dec 19, 2024 · 0 comments
Open
3 tasks

Remove Technical-Failure from Stats #2191

EvanParish opened this issue Dec 19, 2024 · 0 comments

Comments

@EvanParish
Copy link

EvanParish commented Dec 19, 2024

User Story - Business Need

We removed the ability to update notifications with a status of technical-failure but there are a couple remnants left in the stats collection parts of the code so they remain accurate until there can be no more technical failures for it to count.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a backend engineer
I want to ensure the queries we run against the database are efficient
So that they aren't taking unnecessary time looking for metrics that no longer exist.

Additional Info and Resources

Search for the following TODO comment and remove the associated code.

TODO 2191 - remove this after technical-failure is removed from the codebase

Acceptance Criteria

  • Code associated with technical-failure has been removed where they are marked with TODO comments
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

This should only affect generated statistics for BigQuery. As long as the statistics look good the day after this is deployed we can call this successful.

Potential Dependencies

Out of Scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants