From e63ca8dcb8d8fae0f26c5d99956ec8b69afdd9eb Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:06:55 -0600 Subject: [PATCH 01/20] testing1 --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 54 +++++++++++++++++ .github/test13.yml | 58 +++++++++++++++++++ 2 files changed, 112 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/updat_release_issue.md create mode 100644 .github/test13.yml diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md new file mode 100644 index 0000000000..9d5b6292b6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -0,0 +1,54 @@ +--- +name: Release Review Template +about: Template for requesting a production release for VA mobile app +title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" +labels: release +assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson + +--- + +# Release for {{ env.releaseDate }} +This ticket is to control for all the requirements for the upcoming release before the Pull Request is opened. This should hold any tasks or bug fixes unique to the release branch. It should also collect any text for What's New and any content changes for the app stores. + +This ticket should be complete by {{ env.vaDueDate }} +## Release Checklist + +- [ ] What's new content (App Store) - *required* +- [ ] What's new content (In app/Alert Box) - *optional* +- [ ] Content updates + +## Sign-offs: + +- [ ] QA **Due {{ env.qaDueDate }}** +- [ ] Product **Due {{ env.prodDueDate }}** +- [ ] Mobile Release Manager **Due after 10am EST {{ env.vaDueDate }}** + +## Release version + +{{ env.versionNumber }} + +## What's New content (App Store) - *required* + +If there aren't any new features, use standard messaging: We added general improvements and fixed a few bugs. + +If a Flagship team decides to update the App Stores What's New content, their work should be done in a ticket and provided to the release manager, who will then update this section. If not provided, it's assumed not to be used. + +## What's New content (In App/Alert Box) - *optional* + +This work is to be completed by Flagship teams before RC branch is cut and completed by engineering. Flagship team to provide release manager with the ticket this work was completed in for reference. + +## App Store content changes? +All changes should be made to the files in the repo and not directly to the stores. +Indicate NA if no changes. + +- [ ] Images: +- [ ] Content: +- [ ] Other (Privacy Policy, Promotions etc.): + +## Severe bugs: + +{{ env.issues }} + +## Regression Testing +[QA Testrail Regression Test Run Here](^^^Testrail-url^^^) + diff --git a/.github/test13.yml b/.github/test13.yml new file mode 100644 index 0000000000..b2478e1447 --- /dev/null +++ b/.github/test13.yml @@ -0,0 +1,58 @@ +on: + push: + branches: + - chanel-6808-create-system-for-updating-names-on-release-tickets + +jobs: + release_ticket: + if: ${{ contains(github.ref, 'refs/heads/release/') }} + runs-on: ubuntu-latest + outputs: + ticketNumber: ${{steps.create_issue.outputs.number}} + versionNumber: ${{env.VERSION}} + releaseDate: ${{env.RELEASE_DATE}} + qaDueDate: ${{env.QA_DUE_DATE}} + prodDueDate: ${{env.PROD_DUE_DATE}} + vaDueDate: ${{env.VA_DUE_DATE}} + steps: + - run: echo "VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV + - run: echo "QA_DUE_DATE=$(date -d "+2 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - run: echo "PROD_DUE_DATE=$(date -d "+5 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - run: echo "VA_DUE_DATE=$(date -d "+6 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - run: echo "RELEASE_DATE=$(date -d "+13 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - uses: actions/checkout@v3 + - run: echo "${{ secrets.GH_ACTIONS_PAT }}" > token.txt + - run: gh auth login --with-token < token.txt + - run: | + sev1=$(gh issue list -l "sev-1" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) + sev2=$(gh issue list -l "sev-2" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) + header='| Issue | Title | Notes | + |-------|-------|-------| + ' + table="${header}${sev1}${sev2}" + echo 'TABLE<> $GITHUB_ENV + echo "${table}" >> $GITHUB_ENV + echo 'EOF' >> $GITHUB_ENV + - name: Create Release Ticket + uses: JasonEtco/create-an-issue@v2 + with: + filename: .github/ISSUE_TEMPLATE/updat_release_issue.md + env: + versionNumber: ${{ env.VERSION }} + qaDueDate: ${{env.QA_DUE_DATE}} + prodDueDate: ${{env.PROD_DUE_DATE}} + vaDueDate: ${{env.VA_DUE_DATE}} + releaseDate: ${{ env.RELEASE_DATE }} + issues: ${{ env.TABLE }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + id: create_issue + - name: Assign Users to Release Ticket + if: ${{ success() }} + run: | + # Fetch GitHub Group Members + TEAM_MEMBERS=$(gh api orgs/department-of-veterans-affairs/teams/flagship-mobile-release-approvers/members --jq 'map(.login) | join(",")') + ASSIGNEES=$(echo $TEAM_MEMBERS | paste -sd "," -) + ISSUE_NUMBER=${{ steps.create_issue.outputs.number }} + gh issue edit $ISSUE_NUMBER --add-assignee $ASSIGNEES + env: + GITHUB_TOKEN: ${{ secrets.GH_ACTIONS_PAT }} \ No newline at end of file From 92e474b2648afb831cabae72c2d0e4c72a6777c4 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:18:35 -0600 Subject: [PATCH 02/20] fix branch --- .github/test13.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/test13.yml b/.github/test13.yml index b2478e1447..5d3a61609a 100644 --- a/.github/test13.yml +++ b/.github/test13.yml @@ -1,7 +1,7 @@ on: push: branches: - - chanel-6808-create-system-for-updating-names-on-release-tickets + - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members jobs: release_ticket: From 5770591236bdf807e259cc79ef855a4cb1978206 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:22:46 -0600 Subject: [PATCH 03/20] fix branching --- .github/test13.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/test13.yml b/.github/test13.yml index 5d3a61609a..84dec31046 100644 --- a/.github/test13.yml +++ b/.github/test13.yml @@ -1,3 +1,7 @@ + +# test build + +name: '[test] testing' on: push: branches: From e19ef5ee85d717db9d94bd205fbe4248da01f029 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 16:21:56 -0600 Subject: [PATCH 04/20] test1 --- .github/test13.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/test13.yml b/.github/test13.yml index 84dec31046..a1c11fb14a 100644 --- a/.github/test13.yml +++ b/.github/test13.yml @@ -1,7 +1,7 @@ # test build - name: '[test] testing' + on: push: branches: @@ -9,7 +9,6 @@ on: jobs: release_ticket: - if: ${{ contains(github.ref, 'refs/heads/release/') }} runs-on: ubuntu-latest outputs: ticketNumber: ${{steps.create_issue.outputs.number}} From 9ff87d0172a6a2db883cbee37cd13e7988a20622 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 16:29:56 -0600 Subject: [PATCH 05/20] test2 --- .github/{test13.yml => test20.yml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .github/{test13.yml => test20.yml} (96%) diff --git a/.github/test13.yml b/.github/test20.yml similarity index 96% rename from .github/test13.yml rename to .github/test20.yml index a1c11fb14a..030294d695 100644 --- a/.github/test13.yml +++ b/.github/test20.yml @@ -5,7 +5,7 @@ name: '[test] testing' on: push: branches: - - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members + - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members jobs: release_ticket: From d76ec232d7ea0e44272be154a92f3cf739efe6b2 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 16:36:34 -0600 Subject: [PATCH 06/20] workflow not trigger --- .github/test20.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/test20.yml b/.github/test20.yml index 030294d695..80ce2436cb 100644 --- a/.github/test20.yml +++ b/.github/test20.yml @@ -1,6 +1,6 @@ # test build -name: '[test] testing' +name: '[build]' on: push: From 309d72512fa15a26aa6b9e73f594f645a38c9a76 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:22:00 -0600 Subject: [PATCH 07/20] testing assignee tag --- .github/ISSUE_TEMPLATE/Update App Store.md | 2 +- .github/{ => workflows}/test20.yml | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename .github/{ => workflows}/test20.yml (100%) diff --git a/.github/ISSUE_TEMPLATE/Update App Store.md b/.github/ISSUE_TEMPLATE/Update App Store.md index 9c4089a130..735ff62257 100644 --- a/.github/ISSUE_TEMPLATE/Update App Store.md +++ b/.github/ISSUE_TEMPLATE/Update App Store.md @@ -1,5 +1,5 @@ --- -name: Update App Store +name: testing Update App Store about: Template for work needed to update Google, Apple or Va.Gov app store content and images title: Update App Store labels: app store diff --git a/.github/test20.yml b/.github/workflows/test20.yml similarity index 100% rename from .github/test20.yml rename to .github/workflows/test20.yml From b11dc214055952f1e2c5a93a6d234d9fc8e16737 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:45:40 -0600 Subject: [PATCH 08/20] checking if using assignee from md --- .github/ISSUE_TEMPLATE/Update App Store.md | 2 +- .github/ISSUE_TEMPLATE/updat_release_issue.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/Update App Store.md b/.github/ISSUE_TEMPLATE/Update App Store.md index 735ff62257..9c4089a130 100644 --- a/.github/ISSUE_TEMPLATE/Update App Store.md +++ b/.github/ISSUE_TEMPLATE/Update App Store.md @@ -1,5 +1,5 @@ --- -name: testing Update App Store +name: Update App Store about: Template for work needed to update Google, Apple or Va.Gov app store content and images title: Update App Store labels: app store diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md index 9d5b6292b6..ee0f50cbaa 100644 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -1,9 +1,9 @@ --- -name: Release Review Template +name: Testing Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson +assignees: timwright12, IsraelleHub --- From ba50b2d98ceb27e646a17482b293637bc7ebe51e Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:47:11 -0600 Subject: [PATCH 09/20] no assignee on md file --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md index ee0f50cbaa..43d87b261b 100644 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -3,7 +3,7 @@ name: Testing Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: timwright12, IsraelleHub +assignees: --- From 4190fab0df92838d0e875aa9f2c9005ca69c4300 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:56:06 -0600 Subject: [PATCH 10/20] no assignee on md --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md index 43d87b261b..fc4c8e4a54 100644 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -3,7 +3,7 @@ name: Testing Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: + --- From 220c7047ab0fd5d820f9bc20747b7c23104930cc Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 12:07:29 -0600 Subject: [PATCH 11/20] delete md file --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 54 ---------------- .github/workflows/test20.yml | 61 ------------------- 2 files changed, 115 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/updat_release_issue.md delete mode 100644 .github/workflows/test20.yml diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md deleted file mode 100644 index fc4c8e4a54..0000000000 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -name: Testing Release Review Template -about: Template for requesting a production release for VA mobile app -title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" -labels: release - - ---- - -# Release for {{ env.releaseDate }} -This ticket is to control for all the requirements for the upcoming release before the Pull Request is opened. This should hold any tasks or bug fixes unique to the release branch. It should also collect any text for What's New and any content changes for the app stores. - -This ticket should be complete by {{ env.vaDueDate }} -## Release Checklist - -- [ ] What's new content (App Store) - *required* -- [ ] What's new content (In app/Alert Box) - *optional* -- [ ] Content updates - -## Sign-offs: - -- [ ] QA **Due {{ env.qaDueDate }}** -- [ ] Product **Due {{ env.prodDueDate }}** -- [ ] Mobile Release Manager **Due after 10am EST {{ env.vaDueDate }}** - -## Release version - -{{ env.versionNumber }} - -## What's New content (App Store) - *required* - -If there aren't any new features, use standard messaging: We added general improvements and fixed a few bugs. - -If a Flagship team decides to update the App Stores What's New content, their work should be done in a ticket and provided to the release manager, who will then update this section. If not provided, it's assumed not to be used. - -## What's New content (In App/Alert Box) - *optional* - -This work is to be completed by Flagship teams before RC branch is cut and completed by engineering. Flagship team to provide release manager with the ticket this work was completed in for reference. - -## App Store content changes? -All changes should be made to the files in the repo and not directly to the stores. -Indicate NA if no changes. - -- [ ] Images: -- [ ] Content: -- [ ] Other (Privacy Policy, Promotions etc.): - -## Severe bugs: - -{{ env.issues }} - -## Regression Testing -[QA Testrail Regression Test Run Here](^^^Testrail-url^^^) - diff --git a/.github/workflows/test20.yml b/.github/workflows/test20.yml deleted file mode 100644 index 80ce2436cb..0000000000 --- a/.github/workflows/test20.yml +++ /dev/null @@ -1,61 +0,0 @@ - -# test build -name: '[build]' - -on: - push: - branches: - - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members - -jobs: - release_ticket: - runs-on: ubuntu-latest - outputs: - ticketNumber: ${{steps.create_issue.outputs.number}} - versionNumber: ${{env.VERSION}} - releaseDate: ${{env.RELEASE_DATE}} - qaDueDate: ${{env.QA_DUE_DATE}} - prodDueDate: ${{env.PROD_DUE_DATE}} - vaDueDate: ${{env.VA_DUE_DATE}} - steps: - - run: echo "VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV - - run: echo "QA_DUE_DATE=$(date -d "+2 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - run: echo "PROD_DUE_DATE=$(date -d "+5 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - run: echo "VA_DUE_DATE=$(date -d "+6 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - run: echo "RELEASE_DATE=$(date -d "+13 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - uses: actions/checkout@v3 - - run: echo "${{ secrets.GH_ACTIONS_PAT }}" > token.txt - - run: gh auth login --with-token < token.txt - - run: | - sev1=$(gh issue list -l "sev-1" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) - sev2=$(gh issue list -l "sev-2" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) - header='| Issue | Title | Notes | - |-------|-------|-------| - ' - table="${header}${sev1}${sev2}" - echo 'TABLE<> $GITHUB_ENV - echo "${table}" >> $GITHUB_ENV - echo 'EOF' >> $GITHUB_ENV - - name: Create Release Ticket - uses: JasonEtco/create-an-issue@v2 - with: - filename: .github/ISSUE_TEMPLATE/updat_release_issue.md - env: - versionNumber: ${{ env.VERSION }} - qaDueDate: ${{env.QA_DUE_DATE}} - prodDueDate: ${{env.PROD_DUE_DATE}} - vaDueDate: ${{env.VA_DUE_DATE}} - releaseDate: ${{ env.RELEASE_DATE }} - issues: ${{ env.TABLE }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - id: create_issue - - name: Assign Users to Release Ticket - if: ${{ success() }} - run: | - # Fetch GitHub Group Members - TEAM_MEMBERS=$(gh api orgs/department-of-veterans-affairs/teams/flagship-mobile-release-approvers/members --jq 'map(.login) | join(",")') - ASSIGNEES=$(echo $TEAM_MEMBERS | paste -sd "," -) - ISSUE_NUMBER=${{ steps.create_issue.outputs.number }} - gh issue edit $ISSUE_NUMBER --add-assignee $ASSIGNEES - env: - GITHUB_TOKEN: ${{ secrets.GH_ACTIONS_PAT }} \ No newline at end of file From 2b81c3fe43c2913d180267319f9b4ec23c94f513 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 12:07:49 -0600 Subject: [PATCH 12/20] update md --- .github/ISSUE_TEMPLATE/release_ticket.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/release_ticket.md b/.github/ISSUE_TEMPLATE/release_ticket.md index 9d5b6292b6..85ec5d4d37 100644 --- a/.github/ISSUE_TEMPLATE/release_ticket.md +++ b/.github/ISSUE_TEMPLATE/release_ticket.md @@ -3,7 +3,7 @@ name: Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson +assignees: DonMcCaugheyUSDS --- From deb92f33f62ddb67d282973001c27b9e782300d2 Mon Sep 17 00:00:00 2001 From: Brea Blackwelder <5230529+brea11y@users.noreply.github.com> Date: Wed, 11 Dec 2024 21:39:41 +0000 Subject: [PATCH 13/20] Fixing broken links in UX pages --- .../UX/Foundations/Information-Architecture.md | 12 ++++++------ .../docs/UX/Foundations/Research/index.md | 4 ++-- .../docs/UX/How-We-Work/designing-ui.md | 2 +- VAMobile/documentation/docs/UX/Resources.md | 15 +++++++-------- 4 files changed, 16 insertions(+), 17 deletions(-) diff --git a/VAMobile/documentation/docs/UX/Foundations/Information-Architecture.md b/VAMobile/documentation/docs/UX/Foundations/Information-Architecture.md index ee1952145b..46fbec3f81 100644 --- a/VAMobile/documentation/docs/UX/Foundations/Information-Architecture.md +++ b/VAMobile/documentation/docs/UX/Foundations/Information-Architecture.md @@ -16,10 +16,10 @@ The following guiding principles are used to help Veterans find information and * **Informed by Veterans:** IA decisions are based on user research conducted with Veterans, examining their mental models around the organization of common tasks and undertanding of labels, as well as getting feedback on proposed solutions. * **Keeps it simple:** Content is prioiritized and includes only what’s absolutely necessary—the fewer elements (number of levels in the hierarchy, number of screens, number of links on a screen) the better. -References: -[VA.gov Information Architecture (IA) team](https://github.com/department-of-veterans-affairs/va.gov-team/tree/69833737d9fe22b8990bb987e7c50de13205c5d5/platform/information-architecture) -[Best Practices for IA on VA.gov](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/information-architecture/ia-best-practices.md) -[VA.gov Design principles](https://design.va.gov/about/principles) +### References: +* [VA.gov Information Architecture (IA) team](https://github.com/department-of-veterans-affairs/va.gov-team/tree/69833737d9fe22b8990bb987e7c50de13205c5d5/platform/information-architecture) +* [Best Practices for IA on VA.gov](https://github.com/department-of-veterans-affairs/va.gov-team/blob/69833737d9fe22b8990bb987e7c50de13205c5d5/platform/information-architecture/ia-best-practices.md) +* [VA.gov Design principles](https://design.va.gov/about/principles) @@ -68,6 +68,6 @@ The VA Health and Benefits app’s IA contains four top level categories: Home, ## Background The VA Health and Benefits app’s Information Architecture and navigation model are based on the findings and output from a multi-stage, collaborative and cross-functional design and research process: [Information Architecture and Navigation - High Level Project Summary](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/va-mobile-app/ux-design/information-architecture-navigation/High%20Level%20Project%20Summary.md) -* [**Phase I:** Two rounds of card sorting](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-research/information-architecture) (open and closed) with Veterans +* [**Phase I:** Two rounds of card sorting](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-design/information-architecture-navigation#phase-i---information-architecture-research) (open and closed) with Veterans * [**Phase II:** Navigation model design exploration](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-design/information-architecture-navigation#phase-ii---navigation-model-exploration--implementation), audit and comparative analysis -* [**Phase III:** Evaluative testing](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-research/usability-testing/new%20navigation%20usability) with Veterans, including a usability study of the proposed navigation model and sitemap reflected through a low-fidelity prototype \ No newline at end of file +* [**Phase III:** Evaluative testing](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-design/information-architecture-navigation#phase-iii----evaluative-research) with Veterans, including a usability study of the proposed navigation model and sitemap reflected through a low-fidelity prototype \ No newline at end of file diff --git a/VAMobile/documentation/docs/UX/Foundations/Research/index.md b/VAMobile/documentation/docs/UX/Foundations/Research/index.md index 76e85e5dc2..738dd61966 100644 --- a/VAMobile/documentation/docs/UX/Foundations/Research/index.md +++ b/VAMobile/documentation/docs/UX/Foundations/Research/index.md @@ -59,9 +59,9 @@ The research study lead uses the information provided from Perigean, the VA’s - [Sign Up Sheet Template](https://docs.google.com/spreadsheets/d/1N8pTY9LEujEzMWVuI5Bzf0_9yJ_2JpHt/edit?usp=sharing&ouid=118400044101943019619&rtpof=true&sd=true) ## VA Mobile app research -* [VA mobile app UX research on Github](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-research) +* [VA mobile app UX research on Github](https://github.com/department-of-veterans-affairs/va.gov-team/tree/777d2cbccd0121a76011b7b43b74720c875f4f34/products/va-mobile-app/research/ux) Research plans and findings for VA mobile app features and research efforts, 2020 to present. -* [Conducting remote User Research with a pre-release production app build & user credentials](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/va-mobile-app/ux-research/research-operations/research-pre-release-prod-app-build-how-to.md) +* [Conducting remote User Research with a pre-release production app build & user credentials](https://github.com/department-of-veterans-affairs/va.gov-team/blob/cffaa1b43377935e24b90dd6b5b21d4135cf67d4/products/va-mobile-app/research/ux/research-operations/research-pre-release-prod-app-build-how-to.md) Planning tips and a template for conducting remote research with a pre-release production app build. ## VA Research resources diff --git a/VAMobile/documentation/docs/UX/How-We-Work/designing-ui.md b/VAMobile/documentation/docs/UX/How-We-Work/designing-ui.md index ef42b3d57e..fab6f3ba9f 100644 --- a/VAMobile/documentation/docs/UX/How-We-Work/designing-ui.md +++ b/VAMobile/documentation/docs/UX/How-We-Work/designing-ui.md @@ -102,7 +102,7 @@ Once designs are ready to be handed off to the engineering team, you can review - If you notice that QA engineering is not finding bugs that should have been caught in earlier tickets, let QA know, so they can improve their work. ### Launching -- For major features, team members should expect to work with the [Design Librarian](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/UX/How-We-Work/design-librarian) and the Product team to prepare the [app store content](https://didactic-robot-p9wpqpp4wwh99w-3000.app.github.dev/va-mobile-app/docs/Operations/Updating%20the%20App%20Stores). +- For major features, team members should expect to work with the [Design Librarian](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/UX/How-We-Work/design-librarian) and the Product team to prepare the [app store content](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/Operations/Updating%20the%20App%20Stores). ## Moving/Publishing Work diff --git a/VAMobile/documentation/docs/UX/Resources.md b/VAMobile/documentation/docs/UX/Resources.md index acc0eb1e27..3a68ea412b 100644 --- a/VAMobile/documentation/docs/UX/Resources.md +++ b/VAMobile/documentation/docs/UX/Resources.md @@ -8,18 +8,17 @@ VA Mobile app [UX resources on github](https://github.com/department-of-veterans ## Design ### Figma -#### [VA Mobile Team](https://www.figma.com/files/team/1114266503868297401) +#### [VA Mobile Team](https://www.figma.com/files/project/301450677) * Current features, resources, libraries, and design explorations. -#### [Design Library](https://www.figma.com/files/827597988283174959/project/60961499/%F0%9F%93%90-Design-Library?fuid=1114240858371616544) +#### [Design Library](https://www.figma.com/design/QVLPB3eOunmKrgQOuOt0SU/%F0%9F%93%90-Flagship-Library---Resource---VA-Mobile?m=auto) * Finalized components, text styles, and color styles. #### 🚢 Shipped files * Example screens that are in production. - * [Global](https://www.figma.com/file/PpHk9Yyw8dC9xj38AeR9pL/%F0%9F%9A%A2-Global-2.0---Shipped---VA-Mobile?t=i6c9U7y2iqNodqgF-1) - * [Home](https://www.figma.com/file/ddMWiCQCfmUKFhMcYG9fYv/%F0%9F%9A%A2-Home-2.0---Shipped---VA-Mobile?t=i6c9U7y2iqNodqgF-1) & [Profile](https://www.figma.com/file/O6sdr5N7xV6GOZhTPcgY5x/%F0%9F%9A%A2-Profile-2.0---Shipped---VA-Mobile) - * [Benefits](https://www.figma.com/file/p0vlRz38TKIOwWDfI2bGc7/%F0%9F%9A%A2-Benefits-2.0---Shipped---VA-Mobile?t=i6c9U7y2iqNodqgF-1) - * [Health](https://www.figma.com/file/JQAoUBxvSWCzKvu2ifRRE7/%F0%9F%9A%A2-Health-2.0---Shipped---VA-Mobile?t=i6c9U7y2iqNodqgF-1) - * [Payments](https://www.figma.com/file/yhGsaPc2px6eCVzXhuOwm4/%F0%9F%9A%A2-Payments-2.0---Shipped---VA-Mobile?t=i6c9U7y2iqNodqgF-1) + * [Home](https://www.figma.com/design/ddMWiCQCfmUKFhMcYG9fYv/Home-2.0---%F0%9F%9A%A2-Shipped---VA-Mobile?m=auto&t=2n0WqYtVYQ75swD8-6) & [Profile](https://www.figma.com/design/O6sdr5N7xV6GOZhTPcgY5x/Profile-2.0---%F0%9F%9A%A2-Shipped---VA-Mobile?m=auto&t=2n0WqYtVYQ75swD8-6) + * [Benefits](https://www.figma.com/design/p0vlRz38TKIOwWDfI2bGc7/Benefits-2.0---%F0%9F%9A%A2-Shipped---VA-Mobile?m=auto&t=2n0WqYtVYQ75swD8-6) + * [Health](https://www.figma.com/design/JQAoUBxvSWCzKvu2ifRRE7/Health-2.0---%F0%9F%9A%A2-Shipped---VA-Mobile?m=auto&t=2n0WqYtVYQ75swD8-6) + * [Payments](https://www.figma.com/design/yhGsaPc2px6eCVzXhuOwm4/Payments-2.0---%F0%9F%9A%A2-Shipped---VA-Mobile?m=auto&t=2n0WqYtVYQ75swD8-6) ### Balsamiq * [UX brainstorm & work](https://balsamiq.cloud/s4uw4la/pnnwuqv) @@ -32,7 +31,7 @@ VA Mobile app [UX resources on github](https://github.com/department-of-veterans ## Research -* [UX research on Github](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/va-mobile-app/ux-research) +* [UX research on Github](https://github.com/department-of-veterans-affairs/va.gov-team/tree/4b1fcf3124f72b518e91c0af83723bd270ff793f/products/va-mobile-app/research/ux) * Research folders for all VA Mobile app studies. ## VA Design System From 9e273e0de5e7a80a0649ec7f3bc1944bcb0e290d Mon Sep 17 00:00:00 2001 From: Misty Milliron-Grant <102106810+mistymg@users.noreply.github.com> Date: Thu, 12 Dec 2024 15:15:57 +0000 Subject: [PATCH 14/20] Changes to content style guide --- .../Content/content-style-guide.md | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/VAMobile/documentation/docs/Flagship design library/Content/content-style-guide.md b/VAMobile/documentation/docs/Flagship design library/Content/content-style-guide.md index 4b73d20c98..847c4a9961 100644 --- a/VAMobile/documentation/docs/Flagship design library/Content/content-style-guide.md +++ b/VAMobile/documentation/docs/Flagship design library/Content/content-style-guide.md @@ -4,7 +4,7 @@ sidebar_position: 1 --- ## Voice and tone -We follow the [VA design system content principles](https://design.va.gov/content-style-guide/content-principles). In following these principles, we create consistent, clear, and customer-centered content that is based on Veteran feedback. +We follow the [VA design system content principles](https://design.va.gov/content-style-guide/content-principles). In following these principles, we create consistent, clear, and user-centered content that is based on Veteran feedback. In addition, we follow [VA plain language standards](https://design.va.gov/content-style-guide/plain-language/) to help Veterans and their families find and understand the information they need. @@ -12,7 +12,7 @@ Since we create content for health-related features, we also follow the [VA cont ## Accessible and inclusive language We write for all Veterans and those who care for them. Therefore, we use people-first language that is inclusive of the wide range of abilities and experiences of our users. -We avoid words that are insensitive to the disabilities faced by our users. For example, we don’t use “view” or “see,” since a number of our users are blind or low-vision. We also avoid idioms, such as “at your fingertips” or “give an arm or a leg.” Not only are idioms often insensitive to Veterans’ experience but also idioms don’t follow plain language standards. +We avoid words that are insensitive to the disabilities faced by our users. For example, we don’t use “see” since a number of our users are blind or low-vision. We also avoid idioms, such as “at your fingertips” or “give an arm or a leg.” Not only are idioms often insensitive to Veterans’ experience, but also idioms don’t follow plain language standards. Resources to consider: @@ -26,25 +26,22 @@ We follow [VA.gov content style guide rules](https://design.va.gov/content-style ### Capitalization -- Screen names are title case. With the new navigation design, we will [change to sentence case for screen titles](https://github.com/department-of-veterans-affairs/va-mobile-app/issues/2575). -- All other headings in the app are sentence case. -- Buttons - - For native actions, we use title case for iOS and all caps for Android. - - For interface buttons, we use sentence case. - +- For native actions, we use title case for iOS and all caps for Android. +- For interface buttons, we use sentence case. ### Times and time zones -- We currently use `AM` and `PM` (both letters capitalized and no punctuation) since this is default formatting in React Native. +- Due to default formatting in React Native, when times/time zones aren't hardcoded, our formatting differs from VA.gov. For example, React Native formats as `AM` and `PM` (both letters capitalized and no punctuation) and `EST` (three-letter format). +- When times and timezones are hardcoded, we follow the VA.gov content style guide. ## Word choice, spelling, and naming conventions ### Content briefs -We use [content briefs](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/content/content-briefs) to ensure consistent word choice and usage with other VA teams. VA Sitewide Content and IA team creates content briefs, sometimes in collaboration with the VA Mobile App content designer. +We use [content briefs](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/content/content-briefs) to ensure consistent word choice and usage with other VA teams. VA.gov's content team creates content briefs, sometimes in collaboration with the VA Mobile App content designer. ### [Word List](https://design.va.gov/content-style-guide/word-list) We use standard American English spelling in Merriam-Webster Dictionary. The words on the VA.gov word list are exceptions or need clarification. ### [Naming conventions](https://design.va.gov/content-style-guide/naming-and-labels) -We follow VA.gov content style guide’s [rules for naming and labels](https://design.va.gov/content-style-guide/naming-and-labels) for tools, products, benefits, offices, and programs. -In most cases, VA.gov will have already established a name for a tool, benefit, etc. For cases in which we would like to suggest a different name or need help with naming an app-specific feature, we work closely with VA Sitewide Content team to ensure alignment. +We follow VA.gov content style guide’s [rules for naming and labels](https://design.va.gov/content-style-guide/naming-and-labels) for tools, products, benefits, offices, and programs. +In most cases, VA.gov will have already established a name for a tool, benefit, etc. For cases in which we'd like to suggest a different name or need help with naming an app-specific feature, we work closely with VA.gov's content team to ensure alignment. ## Error messages VA.gov’s design system includes a section on [how to help users recover from errors](https://design.va.gov/patterns/help-users-to/recover-from-errors). It details the structure, style, and tone for error and informational messages. From 608bef908ee1d241954eb48245f1fde72719c584 Mon Sep 17 00:00:00 2001 From: Dylan Nienberg <87150991+Sparowhawk@users.noreply.github.com> Date: Thu, 12 Dec 2024 11:41:35 -0600 Subject: [PATCH 15/20] 10313-MoreIconConversionsAgain (#10315) --- VAMobile/src/components/AttachmentLink.tsx | 5 ++-- .../FormFields/FormAttachments.tsx | 30 +++++++++---------- VAMobile/src/components/LabelTag.tsx | 17 ++++++----- VAMobile/src/components/LargeNavButton.tsx | 23 +++++++------- VAMobile/src/components/PhotoPreview.tsx | 12 ++++---- .../src/components/TextLineWithIcon.test.tsx | 4 +-- .../ViewMessage/CollapsibleMessage.tsx | 4 +-- VAMobile/src/styles/themes/standardTheme.ts | 2 +- 8 files changed, 48 insertions(+), 49 deletions(-) diff --git a/VAMobile/src/components/AttachmentLink.tsx b/VAMobile/src/components/AttachmentLink.tsx index 3f0d2e403e..03e0796416 100644 --- a/VAMobile/src/components/AttachmentLink.tsx +++ b/VAMobile/src/components/AttachmentLink.tsx @@ -1,6 +1,8 @@ import React, { FC } from 'react' import { AccessibilityProps, Pressable, PressableProps } from 'react-native' +import { Icon } from '@department-of-veterans-affairs/mobile-component-library' + import { a11yHintProp } from 'utils/accessibility' import { useTheme } from 'utils/hooks' import { featureEnabled } from 'utils/remoteConfig' @@ -8,7 +10,6 @@ import { featureEnabled } from 'utils/remoteConfig' import Box from './Box' import LinkWithAnalytics from './LinkWithAnalytics' import TextView from './TextView' -import VAIcon from './VAIcon' export type AttachmentLinkProps = { /** Name of link/attachment */ @@ -57,7 +58,7 @@ const AttachmentLink: FC = ({ - + {text} diff --git a/VAMobile/src/components/FormWrapper/FormFields/FormAttachments.tsx b/VAMobile/src/components/FormWrapper/FormFields/FormAttachments.tsx index 8c5b11652d..97c14f3a62 100644 --- a/VAMobile/src/components/FormWrapper/FormFields/FormAttachments.tsx +++ b/VAMobile/src/components/FormWrapper/FormFields/FormAttachments.tsx @@ -2,10 +2,10 @@ import React, { FC, ReactNode } from 'react' import { useTranslation } from 'react-i18next' import { ImagePickerResponse } from 'react-native-image-picker/src/types' -import { Button, ButtonVariants } from '@department-of-veterans-affairs/mobile-component-library' +import { Button, ButtonVariants, Icon } from '@department-of-veterans-affairs/mobile-component-library' import _ from 'underscore' -import { Box, TextView, VAIcon } from 'components/index' +import { Box, TextView } from 'components/index' import { NAMESPACE } from 'constants/namespaces' import { DocumentPickerResponse } from 'screens/BenefitsScreen/BenefitsStackScreens' import { getFileDisplay } from 'utils/common' @@ -45,21 +45,19 @@ const FormAttachments: FC = ({ return ( - - - - {text} - + flexDirection={'row'} + mr={theme.dimensions.gutter} + mt={index !== 0 ? theme.dimensions.condensedMarginBetween : 0} + mb={theme.dimensions.condensedMarginBetween}> + + + + {text} +