From e63ca8dcb8d8fae0f26c5d99956ec8b69afdd9eb Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:06:55 -0600 Subject: [PATCH 01/12] testing1 --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 54 +++++++++++++++++ .github/test13.yml | 58 +++++++++++++++++++ 2 files changed, 112 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/updat_release_issue.md create mode 100644 .github/test13.yml diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md new file mode 100644 index 0000000000..9d5b6292b6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -0,0 +1,54 @@ +--- +name: Release Review Template +about: Template for requesting a production release for VA mobile app +title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" +labels: release +assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson + +--- + +# Release for {{ env.releaseDate }} +This ticket is to control for all the requirements for the upcoming release before the Pull Request is opened. This should hold any tasks or bug fixes unique to the release branch. It should also collect any text for What's New and any content changes for the app stores. + +This ticket should be complete by {{ env.vaDueDate }} +## Release Checklist + +- [ ] What's new content (App Store) - *required* +- [ ] What's new content (In app/Alert Box) - *optional* +- [ ] Content updates + +## Sign-offs: + +- [ ] QA **Due {{ env.qaDueDate }}** +- [ ] Product **Due {{ env.prodDueDate }}** +- [ ] Mobile Release Manager **Due after 10am EST {{ env.vaDueDate }}** + +## Release version + +{{ env.versionNumber }} + +## What's New content (App Store) - *required* + +If there aren't any new features, use standard messaging: We added general improvements and fixed a few bugs. + +If a Flagship team decides to update the App Stores What's New content, their work should be done in a ticket and provided to the release manager, who will then update this section. If not provided, it's assumed not to be used. + +## What's New content (In App/Alert Box) - *optional* + +This work is to be completed by Flagship teams before RC branch is cut and completed by engineering. Flagship team to provide release manager with the ticket this work was completed in for reference. + +## App Store content changes? +All changes should be made to the files in the repo and not directly to the stores. +Indicate NA if no changes. + +- [ ] Images: +- [ ] Content: +- [ ] Other (Privacy Policy, Promotions etc.): + +## Severe bugs: + +{{ env.issues }} + +## Regression Testing +[QA Testrail Regression Test Run Here](^^^Testrail-url^^^) + diff --git a/.github/test13.yml b/.github/test13.yml new file mode 100644 index 0000000000..b2478e1447 --- /dev/null +++ b/.github/test13.yml @@ -0,0 +1,58 @@ +on: + push: + branches: + - chanel-6808-create-system-for-updating-names-on-release-tickets + +jobs: + release_ticket: + if: ${{ contains(github.ref, 'refs/heads/release/') }} + runs-on: ubuntu-latest + outputs: + ticketNumber: ${{steps.create_issue.outputs.number}} + versionNumber: ${{env.VERSION}} + releaseDate: ${{env.RELEASE_DATE}} + qaDueDate: ${{env.QA_DUE_DATE}} + prodDueDate: ${{env.PROD_DUE_DATE}} + vaDueDate: ${{env.VA_DUE_DATE}} + steps: + - run: echo "VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV + - run: echo "QA_DUE_DATE=$(date -d "+2 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - run: echo "PROD_DUE_DATE=$(date -d "+5 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - run: echo "VA_DUE_DATE=$(date -d "+6 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - run: echo "RELEASE_DATE=$(date -d "+13 days" '+%A %b %d, %Y')" >> $GITHUB_ENV + - uses: actions/checkout@v3 + - run: echo "${{ secrets.GH_ACTIONS_PAT }}" > token.txt + - run: gh auth login --with-token < token.txt + - run: | + sev1=$(gh issue list -l "sev-1" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) + sev2=$(gh issue list -l "sev-2" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) + header='| Issue | Title | Notes | + |-------|-------|-------| + ' + table="${header}${sev1}${sev2}" + echo 'TABLE<> $GITHUB_ENV + echo "${table}" >> $GITHUB_ENV + echo 'EOF' >> $GITHUB_ENV + - name: Create Release Ticket + uses: JasonEtco/create-an-issue@v2 + with: + filename: .github/ISSUE_TEMPLATE/updat_release_issue.md + env: + versionNumber: ${{ env.VERSION }} + qaDueDate: ${{env.QA_DUE_DATE}} + prodDueDate: ${{env.PROD_DUE_DATE}} + vaDueDate: ${{env.VA_DUE_DATE}} + releaseDate: ${{ env.RELEASE_DATE }} + issues: ${{ env.TABLE }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + id: create_issue + - name: Assign Users to Release Ticket + if: ${{ success() }} + run: | + # Fetch GitHub Group Members + TEAM_MEMBERS=$(gh api orgs/department-of-veterans-affairs/teams/flagship-mobile-release-approvers/members --jq 'map(.login) | join(",")') + ASSIGNEES=$(echo $TEAM_MEMBERS | paste -sd "," -) + ISSUE_NUMBER=${{ steps.create_issue.outputs.number }} + gh issue edit $ISSUE_NUMBER --add-assignee $ASSIGNEES + env: + GITHUB_TOKEN: ${{ secrets.GH_ACTIONS_PAT }} \ No newline at end of file From 92e474b2648afb831cabae72c2d0e4c72a6777c4 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:18:35 -0600 Subject: [PATCH 02/12] fix branch --- .github/test13.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/test13.yml b/.github/test13.yml index b2478e1447..5d3a61609a 100644 --- a/.github/test13.yml +++ b/.github/test13.yml @@ -1,7 +1,7 @@ on: push: branches: - - chanel-6808-create-system-for-updating-names-on-release-tickets + - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members jobs: release_ticket: From 5770591236bdf807e259cc79ef855a4cb1978206 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:22:46 -0600 Subject: [PATCH 03/12] fix branching --- .github/test13.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/test13.yml b/.github/test13.yml index 5d3a61609a..84dec31046 100644 --- a/.github/test13.yml +++ b/.github/test13.yml @@ -1,3 +1,7 @@ + +# test build + +name: '[test] testing' on: push: branches: From e19ef5ee85d717db9d94bd205fbe4248da01f029 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 16:21:56 -0600 Subject: [PATCH 04/12] test1 --- .github/test13.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/test13.yml b/.github/test13.yml index 84dec31046..a1c11fb14a 100644 --- a/.github/test13.yml +++ b/.github/test13.yml @@ -1,7 +1,7 @@ # test build - name: '[test] testing' + on: push: branches: @@ -9,7 +9,6 @@ on: jobs: release_ticket: - if: ${{ contains(github.ref, 'refs/heads/release/') }} runs-on: ubuntu-latest outputs: ticketNumber: ${{steps.create_issue.outputs.number}} From 9ff87d0172a6a2db883cbee37cd13e7988a20622 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 16:29:56 -0600 Subject: [PATCH 05/12] test2 --- .github/{test13.yml => test20.yml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .github/{test13.yml => test20.yml} (96%) diff --git a/.github/test13.yml b/.github/test20.yml similarity index 96% rename from .github/test13.yml rename to .github/test20.yml index a1c11fb14a..030294d695 100644 --- a/.github/test13.yml +++ b/.github/test20.yml @@ -5,7 +5,7 @@ name: '[test] testing' on: push: branches: - - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members + - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members jobs: release_ticket: From d76ec232d7ea0e44272be154a92f3cf739efe6b2 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Thu, 5 Dec 2024 16:36:34 -0600 Subject: [PATCH 06/12] workflow not trigger --- .github/test20.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/test20.yml b/.github/test20.yml index 030294d695..80ce2436cb 100644 --- a/.github/test20.yml +++ b/.github/test20.yml @@ -1,6 +1,6 @@ # test build -name: '[test] testing' +name: '[build]' on: push: From 309d72512fa15a26aa6b9e73f594f645a38c9a76 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:22:00 -0600 Subject: [PATCH 07/12] testing assignee tag --- .github/ISSUE_TEMPLATE/Update App Store.md | 2 +- .github/{ => workflows}/test20.yml | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename .github/{ => workflows}/test20.yml (100%) diff --git a/.github/ISSUE_TEMPLATE/Update App Store.md b/.github/ISSUE_TEMPLATE/Update App Store.md index 9c4089a130..735ff62257 100644 --- a/.github/ISSUE_TEMPLATE/Update App Store.md +++ b/.github/ISSUE_TEMPLATE/Update App Store.md @@ -1,5 +1,5 @@ --- -name: Update App Store +name: testing Update App Store about: Template for work needed to update Google, Apple or Va.Gov app store content and images title: Update App Store labels: app store diff --git a/.github/test20.yml b/.github/workflows/test20.yml similarity index 100% rename from .github/test20.yml rename to .github/workflows/test20.yml From b11dc214055952f1e2c5a93a6d234d9fc8e16737 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:45:40 -0600 Subject: [PATCH 08/12] checking if using assignee from md --- .github/ISSUE_TEMPLATE/Update App Store.md | 2 +- .github/ISSUE_TEMPLATE/updat_release_issue.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/Update App Store.md b/.github/ISSUE_TEMPLATE/Update App Store.md index 735ff62257..9c4089a130 100644 --- a/.github/ISSUE_TEMPLATE/Update App Store.md +++ b/.github/ISSUE_TEMPLATE/Update App Store.md @@ -1,5 +1,5 @@ --- -name: testing Update App Store +name: Update App Store about: Template for work needed to update Google, Apple or Va.Gov app store content and images title: Update App Store labels: app store diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md index 9d5b6292b6..ee0f50cbaa 100644 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -1,9 +1,9 @@ --- -name: Release Review Template +name: Testing Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson +assignees: timwright12, IsraelleHub --- From ba50b2d98ceb27e646a17482b293637bc7ebe51e Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:47:11 -0600 Subject: [PATCH 09/12] no assignee on md file --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md index ee0f50cbaa..43d87b261b 100644 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -3,7 +3,7 @@ name: Testing Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: timwright12, IsraelleHub +assignees: --- From 4190fab0df92838d0e875aa9f2c9005ca69c4300 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:56:06 -0600 Subject: [PATCH 10/12] no assignee on md --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md index 43d87b261b..fc4c8e4a54 100644 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ b/.github/ISSUE_TEMPLATE/updat_release_issue.md @@ -3,7 +3,7 @@ name: Testing Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: + --- From 220c7047ab0fd5d820f9bc20747b7c23104930cc Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 12:07:29 -0600 Subject: [PATCH 11/12] delete md file --- .github/ISSUE_TEMPLATE/updat_release_issue.md | 54 ---------------- .github/workflows/test20.yml | 61 ------------------- 2 files changed, 115 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/updat_release_issue.md delete mode 100644 .github/workflows/test20.yml diff --git a/.github/ISSUE_TEMPLATE/updat_release_issue.md b/.github/ISSUE_TEMPLATE/updat_release_issue.md deleted file mode 100644 index fc4c8e4a54..0000000000 --- a/.github/ISSUE_TEMPLATE/updat_release_issue.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -name: Testing Release Review Template -about: Template for requesting a production release for VA mobile app -title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" -labels: release - - ---- - -# Release for {{ env.releaseDate }} -This ticket is to control for all the requirements for the upcoming release before the Pull Request is opened. This should hold any tasks or bug fixes unique to the release branch. It should also collect any text for What's New and any content changes for the app stores. - -This ticket should be complete by {{ env.vaDueDate }} -## Release Checklist - -- [ ] What's new content (App Store) - *required* -- [ ] What's new content (In app/Alert Box) - *optional* -- [ ] Content updates - -## Sign-offs: - -- [ ] QA **Due {{ env.qaDueDate }}** -- [ ] Product **Due {{ env.prodDueDate }}** -- [ ] Mobile Release Manager **Due after 10am EST {{ env.vaDueDate }}** - -## Release version - -{{ env.versionNumber }} - -## What's New content (App Store) - *required* - -If there aren't any new features, use standard messaging: We added general improvements and fixed a few bugs. - -If a Flagship team decides to update the App Stores What's New content, their work should be done in a ticket and provided to the release manager, who will then update this section. If not provided, it's assumed not to be used. - -## What's New content (In App/Alert Box) - *optional* - -This work is to be completed by Flagship teams before RC branch is cut and completed by engineering. Flagship team to provide release manager with the ticket this work was completed in for reference. - -## App Store content changes? -All changes should be made to the files in the repo and not directly to the stores. -Indicate NA if no changes. - -- [ ] Images: -- [ ] Content: -- [ ] Other (Privacy Policy, Promotions etc.): - -## Severe bugs: - -{{ env.issues }} - -## Regression Testing -[QA Testrail Regression Test Run Here](^^^Testrail-url^^^) - diff --git a/.github/workflows/test20.yml b/.github/workflows/test20.yml deleted file mode 100644 index 80ce2436cb..0000000000 --- a/.github/workflows/test20.yml +++ /dev/null @@ -1,61 +0,0 @@ - -# test build -name: '[build]' - -on: - push: - branches: - - chanel-10321-bug-release-issue-tag-flagship-mobile-approver-members - -jobs: - release_ticket: - runs-on: ubuntu-latest - outputs: - ticketNumber: ${{steps.create_issue.outputs.number}} - versionNumber: ${{env.VERSION}} - releaseDate: ${{env.RELEASE_DATE}} - qaDueDate: ${{env.QA_DUE_DATE}} - prodDueDate: ${{env.PROD_DUE_DATE}} - vaDueDate: ${{env.VA_DUE_DATE}} - steps: - - run: echo "VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV - - run: echo "QA_DUE_DATE=$(date -d "+2 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - run: echo "PROD_DUE_DATE=$(date -d "+5 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - run: echo "VA_DUE_DATE=$(date -d "+6 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - run: echo "RELEASE_DATE=$(date -d "+13 days" '+%A %b %d, %Y')" >> $GITHUB_ENV - - uses: actions/checkout@v3 - - run: echo "${{ secrets.GH_ACTIONS_PAT }}" > token.txt - - run: gh auth login --with-token < token.txt - - run: | - sev1=$(gh issue list -l "sev-1" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) - sev2=$(gh issue list -l "sev-2" --jq 'map("|#\(.number)|\(.title)|") | join("\n") ' --json number,title) - header='| Issue | Title | Notes | - |-------|-------|-------| - ' - table="${header}${sev1}${sev2}" - echo 'TABLE<> $GITHUB_ENV - echo "${table}" >> $GITHUB_ENV - echo 'EOF' >> $GITHUB_ENV - - name: Create Release Ticket - uses: JasonEtco/create-an-issue@v2 - with: - filename: .github/ISSUE_TEMPLATE/updat_release_issue.md - env: - versionNumber: ${{ env.VERSION }} - qaDueDate: ${{env.QA_DUE_DATE}} - prodDueDate: ${{env.PROD_DUE_DATE}} - vaDueDate: ${{env.VA_DUE_DATE}} - releaseDate: ${{ env.RELEASE_DATE }} - issues: ${{ env.TABLE }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - id: create_issue - - name: Assign Users to Release Ticket - if: ${{ success() }} - run: | - # Fetch GitHub Group Members - TEAM_MEMBERS=$(gh api orgs/department-of-veterans-affairs/teams/flagship-mobile-release-approvers/members --jq 'map(.login) | join(",")') - ASSIGNEES=$(echo $TEAM_MEMBERS | paste -sd "," -) - ISSUE_NUMBER=${{ steps.create_issue.outputs.number }} - gh issue edit $ISSUE_NUMBER --add-assignee $ASSIGNEES - env: - GITHUB_TOKEN: ${{ secrets.GH_ACTIONS_PAT }} \ No newline at end of file From 2b81c3fe43c2913d180267319f9b4ec23c94f513 Mon Sep 17 00:00:00 2001 From: IsraelleHub <145595240+IsraelleHub@users.noreply.github.com> Date: Mon, 9 Dec 2024 12:07:49 -0600 Subject: [PATCH 12/12] update md --- .github/ISSUE_TEMPLATE/release_ticket.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/release_ticket.md b/.github/ISSUE_TEMPLATE/release_ticket.md index 9d5b6292b6..85ec5d4d37 100644 --- a/.github/ISSUE_TEMPLATE/release_ticket.md +++ b/.github/ISSUE_TEMPLATE/release_ticket.md @@ -3,7 +3,7 @@ name: Release Review Template about: Template for requesting a production release for VA mobile app title: "{{ env.releaseDate }} Release Sign-Off: {{ env.versionNumber }}" labels: release -assignees: timwright12, chrisj-usds, dumathane, SarahHuber-AdHoc, DonMcCaugheyUSDS, TKDickson +assignees: DonMcCaugheyUSDS ---