Automation Update - Count number of issues detected by Accessibility check and update slack message with that value #10311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexicalninja
requested review from
timwright12,
alexandec,
theodur,
dumathane,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
9 tasks
lexicalninja
added
accessibility
timwright12
reviewed
Dec 4, 2024
|
@lexicalninja can you link up to a slack message of this working? I'm seeing empty returns in the CI example |
Co-authored-by: Tim Wright <[email protected]>
|
@timwright12 i can probably do a couple commits to force a run. the message didnt work because of the issue resolved by #10269 |
|
@timwright12 updated the PR with the workflow run and slack message from a minute ago |
…detected-by-accessibility-check-and-update-slack-message-with-that-value
timwright12
approved these changes
Dec 4, 2024
|
@IsraelleHub let me know if you have any changes that you would like to see before i merge |
|
@lexicalninja Looks very awesome. Thank you for unblocking this! |
IsraelleHub
approved these changes
Dec 4, 2024
lexicalninja
deleted the
8524-automation---count-number-of-issues-detected-by-accessibility-check-and-update-slack-message-with-that-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
closes #8524
This PR updates the a11y check on the doc site to include total number of errors, as well as the total pages with errors that it already reports.
It should out put the following template to the build channel on its regular schedule:
Accessibility issues detected. Please review and fix. Build started by AUTOBOT: REF LINK URL. See :thread: or <www.github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/424242424242> for results. Number of pages with errors: INT Total number of accessibility issues detected: INTScreenshots/Video
Testing
This run
and
This Slack thread
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch