Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use i18n in unit tests - Home 6 #10353

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: use i18n in unit tests - Home 6 #10353

merged 2 commits into from
Dec 13, 2024

Conversation

kimmccaskill-oddball
Copy link
Contributor

Description of Change

Update the unit tests noted in this issue

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@kimmccaskill-oddball kimmccaskill-oddball requested review from a team as code owners December 9, 2024 19:02
@kimmccaskill-oddball kimmccaskill-oddball changed the title chore: use i18n in unit tests chore: use i18n in unit tests - Home 6 Dec 9, 2024
@kimmccaskill-oddball
Copy link
Contributor Author

@timwright12 Hi Tim. This is my last ticket that I need to get submitted for my onboarding, if you or someone could get a look at this. Thank you!

@timwright12
Copy link
Contributor

@kimmccaskill-oddball looks good, feel free to merge

@kimmccaskill-oddball kimmccaskill-oddball merged commit 86880c7 into develop Dec 13, 2024
31 of 33 checks passed
@kimmccaskill-oddball kimmccaskill-oddball deleted the chore/9998-Usei18nInUnitTests-Home-6 branch December 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwright12 timwright12 timwright12 approved these changes

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimmccaskill-oddball @timwright12