-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/5057-streamlineUseIsScreenReaderEnabledHook #10362
chore/5057-streamlineUseIsScreenReaderEnabledHook #10362
Conversation
@TimRoe since you worked on this in the past, if you could take a look, that'd be great |
@alexandec I can, but seeing this will also mention that we ended up adding this hook to the design system and it is being exported as |
@TimRoe thanks for the info, I've updated the PR to use the hook from the component library instead. I removed the hook and the hook docs from our repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, looks good to me.
Only critique is the PR write-up not including that testing should also validate the useAccessibilityFocus
use cases as another hook leveraging the existing one besides the useAutoScrollToElement
mentioned.
Description of Change
Switch to the useIsScreenReaderEnabled hook in the component library. Remove our version of the hook.
Screenshots/Video
Toggling VoiceOver:
voiceover-toggle.mov
Console output when toggling, showing events:
Testing
Reviewer Validations
Check usage of useIsScreenReaderEnabled for regressions:
vama_uses_screen_reader event is also good to check, but I don't think QA has a good way to check it. In the console I can see that it's being sent every time the screen reader is turned off/on. I can also see that it's sent on app load.
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch