Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - sev-3 - All - Add a safety valve into the FE api layer for logging non-JSON responses #9385

Closed
5 tasks
TKDickson opened this issue Aug 15, 2024 · 3 comments
Assignees
Labels
bug Used to identify a bug ticket that will be worked through the bug process Closed - Deployed/Fixed global Issues for the global team QA Tickets require QA work / review QA 1 QA work sized as a 1 sev-3 Lowest bug severity level based on QA bug severity scale - QA to assign this

Comments

@TKDickson
Copy link
Contributor

TKDickson commented Aug 15, 2024

What happened?

We were throwing tons of (ultimately non-useful) errors for a non-JSON response during login - added code in #9266 to get rid of those false positives.

However, we should make sure that if we are receiving responses that have a content type in their header that isn't application/json, we have monitoring to be aware of it and be able to communicate with owning teams if it happens in the future.

Binny came up with something like this as a proposal (and I think that would be a good approach! and yes of course with a viable event name instead of this one):
image.png

Specs:

  • Device:
  • OS:
  • User Account:
  • Accessibility State:

Steps to Reproduce

Desired behavior

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See Bug Tracking for details on severity levels

  • Impact: High Low
  • Frequency: High Low
  • 3 - Low
  • 2 - High
  • 1 - Critical

Linked to Story

Screen shot(s) and additional information

Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

  • Steps to reproduce are defined
  • Desired behavior is added
  • Labels added (front-end, back-end, global, Health, relevant feature, accessibility, etc)
  • Estimate of 1 added (for front-end tickets)
  • Added either to the relevant feature epic (if found during new feature implementation), or the relevant team's bug epic (Global, Health & Benefits, API, QART)
@TKDickson TKDickson added bug Used to identify a bug ticket that will be worked through the bug process global Issues for the global team QA Tickets require QA work / review sev-3 Lowest bug severity level based on QA bug severity scale - QA to assign this labels Aug 15, 2024
@TKDickson
Copy link
Contributor Author

Did a Slack huddle with Binny to confirm the analytics event was firing as designed (screenshot of terminal in PR attached to this ticket), and didn't reintroduce the false alarm JSON error fixed in #9266.

Also confirmed that I can still do initial (UN/PW) and subsequent (biometrics) login on iOS and Android.

@TKDickson
Copy link
Contributor Author

Doesn't require further testing in develop; closing

@TKDickson TKDickson added Closed - Deployed/Fixed QA 1 QA work sized as a 1 labels Aug 16, 2024
@dumathane dumathane self-assigned this Aug 27, 2024
@TKDickson
Copy link
Contributor Author

@dumathane and I met today - this code has been live for two weeks, and we haven't logged a single vama_9385_api_cType event. This is a good sign - scheduling another meeting for a month out, if we still don't see anything logged to this event, we're going to retire it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to identify a bug ticket that will be worked through the bug process Closed - Deployed/Fixed global Issues for the global team QA Tickets require QA work / review QA 1 QA work sized as a 1 sev-3 Lowest bug severity level based on QA bug severity scale - QA to assign this
Projects
None yet
Development

No branches or pull requests

2 participants