Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Update optimization workflow to automatically push changes to release branch through a PR #9687

Open
IsraelleHub opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
bug Used to identify a bug ticket that will be worked through the bug process code upkeep devops QA and Release Label identifies this work is done on the QA and Release Team QA Tickets require QA work / review release-mgmt

Comments

@IsraelleHub
Copy link
Contributor

IsraelleHub commented Sep 24, 2024

The current Optimaze images workflow is trying to directly push changes to the release/vx.x.x branch, which is being rejected by the protected branch settings, as indicated by this error: "remote: - Changes must be made through a pull request."
A solution will be to:
[ ] modify Optimization workflow to create a pull request (PR) for the optimized images.
This will allow the changes to go through the proper review process.
[ ] After observing the behavior for some time, we can now allow it to push changes directly to release/cx.x.x branch
Screenshot 2024-09-24 at 9.59.15 AM.png
Screenshot 2024-09-24 at 10.00.18 AM.png

@IsraelleHub IsraelleHub added bug Used to identify a bug ticket that will be worked through the bug process code upkeep devops QA Tickets require QA work / review release-mgmt labels Sep 24, 2024
@IsraelleHub IsraelleHub self-assigned this Oct 11, 2024
@IsraelleHub IsraelleHub added the QA and Release Label identifies this work is done on the QA and Release Team label Nov 4, 2024
@TKDickson TKDickson added this to the Sprint XXX, release 2.42 milestone Nov 6, 2024
@kellylein kellylein removed this from the v2.42.0 milestone Nov 26, 2024
@IsraelleHub
Copy link
Contributor Author

Holding off on this ticket since VA is working on revamping branch protection rules.
They rolled it out recently and it broke our release a bit, so they pulled it back until they can plan better

@IsraelleHub
Copy link
Contributor Author

IsraelleHub commented Dec 5, 2024

Note: At testing phase - PR URL is empty . Example

  • I created a branch from develop and put it as a base branch in this workflow: It didn't trigger the optimize workflow giving that I haven't merge my branch into develop yet
  • Since it won't create a PR if there are no changes. I created an empty text file and I push it. same result with empty PR url
  • Next step is to test on a more realistic branch release/v0.0.0. if you keep it local and don’t push it up to the repo it’s fine, but if you do it will trigger the release branch workflow unless it is disabled
  • Next will be to try using the github cli to create PR: Docs
  • Also if we could temporarily give that test branch the same branch protection as the release/* branches for testing purposes, that's will be nice. We will try this out after VA is done revamping the branch protection rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to identify a bug ticket that will be worked through the bug process code upkeep devops QA and Release Label identifies this work is done on the QA and Release Team QA Tickets require QA work / review release-mgmt
Projects
None yet
Development

No branches or pull requests

3 participants