Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link/Icon - Update unit tests related to crash fix defensive code changes #574

Open
3 tasks
TimRoe opened this issue Oct 31, 2024 · 0 comments
Open
3 tasks
Labels
design-system front-end Ticket requires front-end work

Comments

@TimRoe
Copy link
Contributor

TimRoe commented Oct 31, 2024

Description

This is a follow-up ticket to changes from PR #573 and associated with flagship ticket 9064. Functional enhancements/adjustments were made with that ticket that did not receive corresponding unit test additions due to the time constraints to ensure the changes themselves were available to flagship in a timely manner such that they can make the next flagship release to validate if the changes address the underlying crashing problem.

Acceptance Criteria

  • Add/update useExternalLink unit tests to validate the new analytics/promise failure cases
    • With http URLs
    • With non-http URLs
  • Add Icon unit tests
    • For new noIcon prop for null passthrough
    • For new alignWithTextLineHeight prop that wraps the icon in a View that keeps it visually aligned with text of line height sent
  • Add/update Link unit tests
    • No clear of explicit needed updates, but potentially something around the Icon changes and Spacer separating
    • May be able to remove some tests that are now within Icon due to the changes
@TimRoe TimRoe added design-system front-end Ticket requires front-end work labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-system front-end Ticket requires front-end work
Projects
None yet
Development

No branches or pull requests

1 participant