You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow-up ticket to changes from PR #573 and associated with flagship ticket 9064. Functional enhancements/adjustments were made with that ticket that did not receive corresponding unit test additions due to the time constraints to ensure the changes themselves were available to flagship in a timely manner such that they can make the next flagship release to validate if the changes address the underlying crashing problem.
Acceptance Criteria
Add/update useExternalLink unit tests to validate the new analytics/promise failure cases
With http URLs
With non-http URLs
Add Icon unit tests
For new noIcon prop for null passthrough
For new alignWithTextLineHeight prop that wraps the icon in a View that keeps it visually aligned with text of line height sent
Add/update Link unit tests
No clear of explicit needed updates, but potentially something around the Icon changes and Spacer separating
May be able to remove some tests that are now within Icon due to the changes
The text was updated successfully, but these errors were encountered:
Description
This is a follow-up ticket to changes from PR #573 and associated with flagship ticket 9064. Functional enhancements/adjustments were made with that ticket that did not receive corresponding unit test additions due to the time constraints to ensure the changes themselves were available to flagship in a timely manner such that they can make the next flagship release to validate if the changes address the underlying crashing problem.
Acceptance Criteria
useExternalLink
unit tests to validate the new analytics/promise failure caseshttp
URLshttp
URLsnoIcon
prop for null passthroughalignWithTextLineHeight
prop that wraps the icon in a View that keeps it visually aligned with text of line height sentThe text was updated successfully, but these errors were encountered: