Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS - Use preprocessors to filter out VADS web font tokens #604

Open
1 task
narin opened this issue Dec 6, 2024 · 0 comments
Open
1 task

DS - Use preprocessors to filter out VADS web font tokens #604

narin opened this issue Dec 6, 2024 · 0 comments
Labels
design-system front-end Ticket requires front-end work

Comments

@narin
Copy link
Contributor

narin commented Dec 6, 2024

Description

This ticket is blocked by the ticket to update style-dictionar to 4.0. (#507)

Somewhere between css-library versions ^0.11.0 and ^0.16.0, the VADS web team added some font tokens that have conflicting names with our mobile font tokens. Since font tokens won't be shared between web and mobile, we want to exclude them from our token build. We are already doing so with the filter/fonts/is-mobile-font filter, but we have to declare that filter for several files in our style dictionary config which isn't ideal.

style-dictionary 4.0 introduced preprocessors which should allow us to remove all VADS Web font tokens before they are run through our build and simplify our config code.

Acceptance Criteria

  • Once style-dictionary has been updated to 4.0, replace is-mobile-font filter with preprocessor
    Accessibility Requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-system front-end Ticket requires front-end work
Projects
None yet
Development

No branches or pull requests

1 participant