Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACapi: discovery: can stale selectors be updated on success #100042

Open
wesrowe opened this issue Jan 6, 2025 · 1 comment
Open

ACapi: discovery: can stale selectors be updated on success #100042

wesrowe opened this issue Jan 6, 2025 · 1 comment
Assignees
Labels
Cartographers MHV on VAgov team needs-refinement Identifies tickets that need to be refined

Comments

@wesrowe
Copy link
Contributor

wesrowe commented Jan 6, 2025

Description

User story

As a Cartography team member, I want to see if stale MHV selectors – i.e., ones based on MPI rather than the ACapi call – can be updated by a successful ACapi call, so that Veteran experiences that use those selectors can benefit from the ACapi automatically.

Notes

  • Kevin documented some of the staleness details in a canvas (look right below the tracker tables)
  • Joe Niquette of Identity team added a feature in which the AC-API is called on sign-in.

Possible tasks:

  • Determine if Niquette's API response is stored in state
    • If so, is it using user.profile.mhvAccountState?
  • If Niquette isn't using user.profile.mhvAccountState, then our ac-api logic should be selecting for his state instead of user.profile.mhvAccountState
  • Determine if there is a reducer for user.profile.mhvAccountState or whatever state Niquette's response is saved to
  • Make use of said reducer when we make our call to the AC-API

Acceptance criteria

  • The Cartography team has a more perfect (documented) understanding of the source of the FE's source of truth for the user's MHV account status
  • The mhv landing page updates the same state that the sign-in logic does.
  • alert-standardization docs reflect the correct selector for all tool teams
  • QA review
  • A11y review
@wesrowe wesrowe added Cartographers MHV on VAgov team needs-refinement Identifies tickets that need to be refined labels Jan 6, 2025
@wesrowe wesrowe moved this to Next Refinement in Cartographers / MHV Home Jan 6, 2025
@kjsuarez
Copy link
Contributor

kjsuarez commented Jan 7, 2025

Related conversation

TL;DR
The api call at login does update user.profile.mhvAccountState so all this ticket needs to wory about is finding/implementing a reducer (bullet 2 of AC)

@kjsuarez kjsuarez self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cartographers MHV on VAgov team needs-refinement Identifies tickets that need to be refined
Projects
Status: Next Refinement
Development

No branches or pull requests

2 participants