Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rep phone number causes 21-22a PDF generation error #101149

Closed
oddball-lindsay opened this issue Jan 15, 2025 · 6 comments
Closed

Missing rep phone number causes 21-22a PDF generation error #101149

oddball-lindsay opened this issue Jan 15, 2025 · 6 comments
Assignees
Labels
accredited-representation-management-team Accredited Representation Management team backend bug Something isn't working

Comments

@oddball-lindsay
Copy link
Contributor

oddball-lindsay commented Jan 15, 2025

Background

We are requiring a rep's phone number when generating the 21-22a PDF, but not all attorneys and claims agents have a phone number on file. This is causing the PDF generation to error out.

To address:

  1. We will remove the phone number validation from the 21-22a PDF generation to stop this piece from erroring out (@opticbob)
  2. We will query how many attorneys and claims agents are missing a phone number (@holdenhinkle)
  3. We will discuss with stakeholders on if this field is truly required for PDF generation, and if so, what happens when there is no phone number in the OGC database. (@oddball-lindsay)

Slack discussion

@oddball-lindsay
Copy link
Contributor Author

There are 968 attorneys or claims agents that don't have phone_number. This makes up 17% of the 5,646 total attorneys and claims agents.

@opticbob
Copy link

The fix for the PDF error is team reviewed and waiting on Platform.

@opticbob
Copy link

The PDF fix has been approved by Platform and merged.

@oddball-lindsay
Copy link
Contributor Author

oddball-lindsay commented Jan 16, 2025

Putting this in UX Review, I'd like to try Appoint in production with a rep that is missing a phone number (Spencer Lord). Just waiting for the Prod deployment.

@oddball-lindsay
Copy link
Contributor Author

We will discuss with stakeholders on if this field is truly required for PDF generation, and if so, what happens when there is no phone number in the OGC database.

Adding that stakeholders have advised the rep phone number field is not required for processing a 21-22a, so we're okay to not require this for PDF generation!

@oddball-lindsay
Copy link
Contributor Author

Looks good @opticbob 🎉

Tested with Spencer Lord who doesn't have a phone number, and the PDF generated:
Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-representation-management-team Accredited Representation Management team backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants