-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add character limits for Appoint a Representative #96027
Comments
This is looking 99% good. The only area where the character limits are not being enforced is
When a non-United States country is selected, the user has the option to free-fill that field (no longer restricted to a dropdown box) and there are no character limitations. This is affecting all pages where a State/Province/Region can be entered:
Steps to reproduce:
@holdenhinkle I wonder if you could take a look on Tues morning? This would take priority over the focus cleanup. I'm curious about level of effort, particularly if it's a simple fix or if character limitations would have to be implemented for each country. |
Leaning towards moving forward with MVP release and addressing this frontend character limitations later in #100333. We can still rely on backend truncation to ensure the PDF is generated. |
Background
The fields on the 21-22 and 21-22a paper/PDF forms have boxes to write each character in and we have decided to match this functionality on the frontend of our Appoint MVP experience. In this context, a "character" can be a letter, number, space, or special character (e.g. hyphen, period).
While our stakeholders have not explicitly said that the fields in these forms have character limitations, the VA Forms team has shared a risk that they've overcome where extending beyond the boxes (i.e. the character limit) may cause the form to be rejected by any automated or manual processing.
We absolutely do not want our generated PDFs from Appoint a Representative to cause issues with downstream processing, so to be safe we need to instill the following character limitations on the frontend.
Implementation notes:
Tasks
Implement character limits on the following pages and related fields, as follows. We can reference the schema file for this: #93506
/claimant-relationship
/claimant-personal-information
/claimant-contact-mailing
/claimant-contact-phone-email
/veteran-personal-information
/veteran-contact-mailing
/veteran-contact-phone-email
/veteran-identification
Acceptance Criteria
The text was updated successfully, but these errors were encountered: