Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add character limits for Appoint a Representative #96027

Closed
22 tasks done
oddball-lindsay opened this issue Oct 29, 2024 · 4 comments
Closed
22 tasks done

Add character limits for Appoint a Representative #96027

oddball-lindsay opened this issue Oct 29, 2024 · 4 comments
Labels
accredited-representation-management-team Accredited Representation Management team frontend mvp Initial version of thing

Comments

@oddball-lindsay
Copy link
Contributor

oddball-lindsay commented Oct 29, 2024

Background

The fields on the 21-22 and 21-22a paper/PDF forms have boxes to write each character in and we have decided to match this functionality on the frontend of our Appoint MVP experience. In this context, a "character" can be a letter, number, space, or special character (e.g. hyphen, period).

While our stakeholders have not explicitly said that the fields in these forms have character limitations, the VA Forms team has shared a risk that they've overcome where extending beyond the boxes (i.e. the character limit) may cause the form to be rejected by any automated or manual processing.

I think if the PDF limits what you can submit and you are submitting through central mail, you need to make sure anything you do won't cause the form to be rejected by any automated or manual processing. We've been told we can't extend outside of boxes because of OCR scanners. But each form may be different. We particularly have had to pay attention to this when a Form asks for apt/unit number and only allows a certain number of characters

We absolutely do not want our generated PDFs from Appoint a Representative to cause issues with downstream processing, so to be safe we need to instill the following character limitations on the frontend.

Implementation notes:

  • There is already formatting/character limitations for SSN, Date of Birth, and Telephone inputs, so we don't need to add additional logic to check these fields.
  • There are some fields that the user won't be typing in themselves, in which case we will need to truncate on the backend when filling out the PDF form. That backend work will be handled in Ensure form inputs are within form character limitations #96028.

Tasks

Implement character limits on the following pages and related fields, as follows. We can reference the schema file for this: #93506

/claimant-relationship

  • 42 characters for the "Describe your relationship to the Veteran" open input

/claimant-personal-information

  • 12 characters for the First Name
  • 1 character for the Middle Initial
  • 18 characters for the Last Name

/claimant-contact-mailing

  • 30 characters for No. & Street (Street address)
  • 5 characters for Apt./Unit Number (Street address line 2)
  • 18 characters for City
  • 2 characters for State/Province/Region
  • 9 characters for Zip Code/Postal Code

/claimant-contact-phone-email

  • 31 characters for Email address

/veteran-personal-information

  • 12 characters for the First Name
  • 1 character for the Middle Initial
  • 18 characters for the Last Name

/veteran-contact-mailing

  • 30 characters for No. & Street (Street address)
  • 5 characters for Apt./Unit Number (Street address line 2)
  • 18 characters for City
  • 2 characters for State/Province/Region
  • 9 characters for Zip Code/Postal Code

/veteran-contact-phone-email

  • 61 characters for Email address

/veteran-identification

  • 9 characters for Veteran's VA File Number
  • 9 characters for Veteran's Service Number

Acceptance Criteria

  • The frontend will enforce character limitations that match the forms, so that the generated PDF at the end of the experience does not introduce any issues with downstream processing.
@rjohnson2011
Copy link
Contributor

@rjohnson2011
Copy link
Contributor

@oddball-lindsay
Copy link
Contributor Author

oddball-lindsay commented Jan 7, 2025

This is looking 99% good. The only area where the character limits are not being enforced is

2 characters for State/Province/Region

When a non-United States country is selected, the user has the option to free-fill that field (no longer restricted to a dropdown box) and there are no character limitations.

This is affecting all pages where a State/Province/Region can be entered:

  • claimant-contact-mailing (non-Veteran user)
  • veteran-contact-mailing-address (non-Veteran user)
  • veteran-contact-mailing (Veteran user)

Steps to reproduce:

  1. On the screens above, select a non-US country
  2. Enter text into the State/Province Region field and observe that there are no character limitations.

@holdenhinkle I wonder if you could take a look on Tues morning? This would take priority over the focus cleanup. I'm curious about level of effort, particularly if it's a simple fix or if character limitations would have to be implemented for each country.

@oddball-lindsay oddball-lindsay removed their assignment Jan 7, 2025
@oddball-lindsay
Copy link
Contributor Author

oddball-lindsay commented Jan 7, 2025

Leaning towards moving forward with MVP release and addressing this frontend character limitations later in #100333. We can still rely on backend truncation to ensure the PDF is generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-representation-management-team Accredited Representation Management team frontend mvp Initial version of thing
Projects
None yet
Development

No branches or pull requests

3 participants