Midpoint Review - Accessibility Feedback - govcio-vebt, Statement of Assurance of Compliance with 85% Enrollment Ratios (VA Form 22-10215), VA Form 22-10215

[briandeconinck]

Next Steps for the VFS team

• Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
• Comment on this ticket:
  • If the Platform reviewer has any Thoughts/Questions that require responses.
  • When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
  • When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
• Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
• Close the ticket when all feedback has been addressed.

Thoughts/questions

• Sorry for the delayed written feedback. After my out of office last week it's taken me a while to catch up.
• Lots of good stuff here! Thank you for doing so much to address the feedback I provided at the Design Intent!
• Matt and Martha both encouraged you to have the upload portal tested for accessibility. I'd recommend reaching out to the CAIA team for that sooner rather than later, and please tag me in as necessary.

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

• Should: In the meeting Keegan commented on the one instance of hint text being used to provide calculation instructions in context feeling awkward, and yeah --- I led you astray there. Since it's the only one that's short enough to be included in the hint text, it's fine to leave that off and keep all of the calculation instructions on the other page.
• Coding note: You mentioned using an aria-label on the "How is this calculated?" additional info components, but looking in Storybook I don't think aria-label is a supported prop. I think there's a decent case to make for making it a supported property for the web component, but that will have to go through the Design System Team's request process. Note that just adding an aria-label attribute to the <va-additional-info ...> component may not work for all screen readers. Web components and ARIA don't always play well together, so a prop would need to be explicitly added to the component. If you don't want to wait on the DST, your other option would be to rephrase the visible text so they're distinct.

Governance team actions

• Format feedback as individual tasks (check boxes)
• Assign this ticket to the VFS team member that opened the Slack request
• Add the VFS team product label
• Add the VFS team the feature label (if applicable)
• Add the touchpoint labels
• Add the practice area labels
• Add the Collaboration Cycle initiative milestone