21-22: Authorizations in PDF do not reflect user's input

[oddball-lindsay]

Expected vs. Actual

Expected: The PDF download should have the appropriate authorizations specified, based on the user's input in the Appoint experience.

Actual: The PDF download doesn't seem to check any boxes, despite saying yes to the medical and address authorizations in the Appoint experience.

It seems this is because the frontend is not sending the boolean values to the backend.

• consentAddressChange needs to be a yes/no boolean value
• recordConsent needs to be a yes/no boolean value
• consentLimits that are selected in the frontend aren't being submitted in the request, when they are submitted they need to be in the format: ["ALCOHOLISM ", "DRUG_ABUSE", "HIV", "SICKLE_CELL"].

Steps to Reproduce

Approving authorizations:

1. Select a VSO representative accredited with multiple organizations (I chose Lindsay B Berge)
2. Navigate through the experience to the authorization chapter
3. Select "Yes they can access all..." for the medical authorization
4. Select "Yes..." for the address authorization
5. Proceed to download the PDF
6. The PDF should have Field 19 and Field 21 checked, but these are both unchecked

[oddball-lindsay]

Unable to generate the 21-22 at this time, so I cannot confirm if these changes are in place.

[oddball-lindsay]

The "all authorized" and "none authorized" experiences seem to be filling the form out as expected.

I'm not sure though if the "some authorized" is quite right for the medical experience. If I authorize only Drug Abuse in Appoint, then the form has only Drug Abuse checked in Field 20. But the way that field is phrased, it seems like Drug Abuse should actually be the only box unchecked and all other boxes should be checked as an "opt out" concept.

Sent an email to stakeholders to confirm what the right way to approach this is.

[oddball-lindsay]

After checking with stakeholders, we do need to take the opposite approach for Field 20 on the 21-22. It's tricky because the frontend asks which records the Veteran wants to disclose. But then the backend on the form needs to check the opposite records, indicating (again on the form) which records should not be disclosed.

Expectation:
I authorize only Drug Abuse in Appoint, Drug Abuse should actually be the only box unchecked in Field 20 and all other boxes should be checked as an "opt out" concept.

Steps to Reproduce:

1. Select a VSO representative (I chose Lindsay B Berge)
2. Navigate through the experience to the authorization chapter
3. Select "Yes they can access some..." for the medical authorization
4. Select the "Drug abuse" option on the next page
5. Proceed through the Review page and download the PDF
6. The 21-22 PDF should have
   1. Field 19 is checked to indicate general authorization.
   2. Field 20 has the boxes for Alcoholism, HIV and Sickle Cell Anemia checked to indicate the authorization above (in Field 19) does not apply to these particular records. The Drug Abuse box remains unchecked to indicate those records are authorized.

@cosu419 @opticbob is this a frontend fix, where we change what is passed to the backend? Or is this a backend fix, where we change how the backend interprets what the frontend is currently sending over?

[oddball-lindsay]

Chatted in standup and this is a backend fix, so we'll tackle that update over in #98295