Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link behavior and routing #96851

Closed
5 tasks done
oddball-lindsay opened this issue Nov 11, 2024 · 5 comments
Closed
5 tasks done

Fix link behavior and routing #96851

oddball-lindsay opened this issue Nov 11, 2024 · 5 comments
Assignees
Labels
accredited-representation-management-team Accredited Representation Management team bug Something isn't working frontend mvp Initial version of thing

Comments

@oddball-lindsay
Copy link
Contributor

oddball-lindsay commented Nov 11, 2024

We have uncovered some issues with link behavior that should be updated before launch:

  • introduction - the authenticated action links at the top AND bottom of the page should read "Fill out your form to request help" (currently reads "Request help from a VA accredited representative or VSO").
  • representative-select - the "Find a VA accredited..." link at the bottom of the page should open in a new tab (currently opening in the same window).
  • claimant-contact-mailing - the "Find out how to change your address..." link for authenticated users should open va.gov/change-address in a new tab (currently opening the va.gov homepage in the same window).
  • veteran-contact-mailing - the "Find out how to change your address..." link for authenticated users should open va.gov/change-address in a new tab (currently opening the va.gov homepage in the same window).
  • next-steps - the "Learn how to submit your form" link should open our landing page get-help-from-accredited-representative in a new tab (currently pointing to next-steps).
@cosu419
Copy link

cosu419 commented Nov 25, 2024

Introduced an issue with the form title - quick change which will be on my PR tomorrow.

@oddball-lindsay oddball-lindsay self-assigned this Nov 25, 2024
@oddball-lindsay
Copy link
Contributor Author

Looking over this and there are still things to address:

  1. The intro page link for authenticated users does not have the right copy
  2. The links for claimant-contact-mailing and veteran-contact-mailing authenticated experience do now open in a new tab, but they should be pointing to va.gov/change-address -- they are just pointing to the homepage which isn't as helpful.

I've unchecked the tasks above to reflect what is not yet complete.

Currently unable to generate the PDF and access the next-steps page to confirm the last piece.

Happy to spend some time together if it helps untangle these smaller details!

@oddball-lindsay
Copy link
Contributor Author

Thanks @cosu419 the Introduction page link is looking good 👍

I'm not 100% sure the links for claimant-contact-mailing and veteran-contact-mailing are quite right though. They're both linking to https://staging.va.gov/change-address/ but I think it should be a production link https://va.gov/change-address/ ...unless that automatically updates when we push the product to Production? 🤔

@cosu419
Copy link

cosu419 commented Dec 3, 2024

@oddball-lindsay correct, that is dynamic and will auto-update to va.gov in prod.

@oddball-lindsay
Copy link
Contributor Author

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-representation-management-team Accredited Representation Management team bug Something isn't working frontend mvp Initial version of thing
Projects
None yet
Development

No branches or pull requests

2 participants