Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide search feedback to the user #96856

Closed
4 tasks done
oddball-lindsay opened this issue Nov 11, 2024 · 2 comments
Closed
4 tasks done

Provide search feedback to the user #96856

oddball-lindsay opened this issue Nov 11, 2024 · 2 comments
Assignees
Labels
accredited-representation-management-team Accredited Representation Management team frontend mvp Initial version of thing

Comments

@oddball-lindsay
Copy link
Contributor

oddball-lindsay commented Nov 11, 2024

Expected

When no search results are found, the "No results found for [input]... " content should appear below the search box as an h4:
Image

When search results are found, "Showing x results for [input]." content should appear below the search box, but above the search results.
Image

Actual

There is is feedback to the user, whether or not search results are found. They simply see (or don't see) any search results on the page. This is an issue especially for AT users.

Steps to Reproduce

No search results:

  1. Enter "Lindsay Janelle" in the representative search
  2. Select the "Search" button - no visual changes to the apge

Search results:

  1. Enter "John" in the representative search
  2. Search results appear below, but there is no summary displayed above the search results.

Designs

  1. Empty state
  2. Search with # of search results

Acceptance Criteria

  • The number of search results are summarized in an h4, when there are search results returned.
  • The user is provided feedback that no results are found in an h4, when no search results are returned.
  • After a search is performed, focus moves to the h4 search feedback.
  • The h4 search feedback should be wrapped in a live region so that the status can be announced by a screen reader.
@oddball-lindsay oddball-lindsay added accredited-representation-management-team Accredited Representation Management team bug Something isn't working frontend mvp Initial version of thing labels Nov 11, 2024
@oddball-lindsay oddball-lindsay changed the title When no rep search results are found, there is no feedback to the user Provide search feedback to the user Nov 14, 2024
@oddball-lindsay oddball-lindsay removed the bug Something isn't working label Nov 14, 2024
@oddball-lindsay
Copy link
Contributor Author

oddball-lindsay commented Dec 12, 2024

This was flagged as launch-blocking from Staging Review:

Please close the related Staging Review tickets when this has been addressed!

@oddball-lindsay
Copy link
Contributor Author

Looks good, thank you! I'll close out the related Staging Review tickets too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accredited-representation-management-team Accredited Representation Management team frontend mvp Initial version of thing
Projects
None yet
Development

No branches or pull requests

2 participants