Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery - Investigate Cross App Imports to Ensure Compliance (DUE 2/3/2025) #96879

Closed
7 tasks
OptionSelect opened this issue Nov 12, 2024 · 1 comment
Closed
7 tasks
Assignees
Labels
vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)

Comments

@OptionSelect
Copy link
Contributor

Description

Noticed the following warning in Aaron's latest pr. Per convo with Andrew creating ticket for discovery to make sure we're all square!

WARNING This PR contains changes related to an application that is currently not isolated. As of Feb 3, 2025 deployment may no longer be possible for apps that are not isolated. Please isolate this app from other directories in 'src/applications' to prevent future deployment issues. More information on your app's status can be seen here: https://department-of-veterans-affairs.github.io/veteran-facing-services-tools/frontend-support-dashboard/cross-app-import-report Please reach out to Frontend Platform Support with any questions.

PR: https://github.com/department-of-veterans-affairs/vets-website/pull/32955/files?diff=split&w=1

Tasks

  • Confirm / remove cross app imports to align with Platform requirements

Design and Front End sync on implementation of design

  • Required
  • Complete
  • [ X ] Not Required

Acceptance criteria

  • Item one from the description performs as described in the description
  • Item two from the description performs as described in the description

Testing

  • N/A if non development work
  • Testing passed and documented in this ticket based off the "Then" statement in the description

Testing procedure:
If additional testing steps or credentials to perform testing are needed list them here

@OptionSelect OptionSelect added frontend vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2) labels Nov 12, 2024
@OptionSelect OptionSelect self-assigned this Nov 12, 2024
@OptionSelect OptionSelect added the unplanned-work Work that was not planned for during Sprint Planning label Nov 12, 2024
@Tom-Davis Tom-Davis removed frontend unplanned-work Work that was not planned for during Sprint Planning labels Dec 16, 2024
@OptionSelect
Copy link
Contributor Author

Investigated FSR and found that it is the WIZARD_STATUS_COMPLETE const that we are using. Next steps is to replace/remove from application prior to 2/3/2025.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)
Projects
None yet
Development

No branches or pull requests

2 participants