Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-api: Implement MHV Landing Page for 4 "user-action" errors #97281

Closed
1 of 9 tasks
wesrowe opened this issue Nov 16, 2024 · 11 comments
Closed
1 of 9 tasks

AC-api: Implement MHV Landing Page for 4 "user-action" errors #97281

wesrowe opened this issue Nov 16, 2024 · 11 comments
Assignees
Labels
Cartographers MHV on VAgov team engineering Engineering topics

Comments

@wesrowe
Copy link
Contributor

wesrowe commented Nov 16, 2024

Description

User story

As a Veteran for whom the MHV Acct Creation API returned an error requiring MHV Help Desk intervention, I want to be informed on the MHV Landing Page of the issue, which tools are affected, what number to call, and what error code to tell them, so that I can get it resolved efficiently.

Notes

Screenshot

Image

Possible tasks:

  • CONFIRMED: we have to make an API call to get it
  • Add new alert for user-facing errors returned from the Account Creation API
  • This alert will conditionally reveal the specific error codes that require the user to take an action (call the My HealtheVet helpdesk) to resolve the problem.

Acceptance criteria

  • Loading indicator displays while awaiting API response
  • Red alert displays if any of the 4 error codes are returned (below) & conditionally reveals the error code # in the alert heading & body content:
    • 801
    • 805
    • 806
    • 807
  • Gray boxes for SM, Meds and Records display error instead of links (and icons in headings change to reflect the "error" icon)
  • Alert records event to GA4 with heading metadata (similar to e.g. "Register" alert)
  • Remove the current 'Register wtih My HealtheVet" alert for users who see these 4 alerts.
  • QA review
  • A11y review
@wesrowe wesrowe added Cartographers MHV on VAgov team my-health former "health-apartment" tag - Migrating MHV to va.gov needs-refinement Identifies tickets that need to be refined labels Nov 16, 2024
@wesrowe wesrowe changed the title Copy of BLANK Cartographers ticket Eng: AC-api: MHV Landing Page for 4 user-facing errors Nov 18, 2024
@wesrowe wesrowe added the engineering Engineering topics label Nov 18, 2024
@wesrowe wesrowe changed the title Eng: AC-api: MHV Landing Page for 4 user-facing errors AC-api: Implement MHV Landing Page for 4 user-facing errors Nov 18, 2024
@wesrowe wesrowe changed the title AC-api: Implement MHV Landing Page for 4 user-facing errors AC-api: Implement MHV Landing Page for 4 "user-action" errors Nov 18, 2024
@wesrowe wesrowe added star-cartographer and removed my-health former "health-apartment" tag - Migrating MHV to va.gov star-cartographer labels Nov 19, 2024
@wesrowe
Copy link
Contributor Author

wesrowe commented Nov 20, 2024

Planning: estimate to 8 if there's an API call required to get the error code

@wesrowe wesrowe removed the needs-refinement Identifies tickets that need to be refined label Nov 20, 2024
@kjsuarez kjsuarez self-assigned this Nov 21, 2024
@wesrowe wesrowe moved this to Current Sprint in Cartographers / MHV Home Nov 21, 2024
@dcloud
Copy link
Contributor

dcloud commented Nov 22, 2024

@kjsuarez We do need to make an API call to get the errors, per this MHV User Account API doc.

We also need to add a Loading Indicator given this API could take many seconds in worst case, and we want to indicate to the user that we are checking for MHV account

@kjsuarez
Copy link
Contributor

Branch
PR

@wesrowe
Copy link
Contributor Author

wesrowe commented Nov 26, 2024

I just added an AC to make sure a GA4 event is triggered when the alert renders, similar to other alerts on the page.

@kjsuarez
Copy link
Contributor

@kjsuarez
Copy link
Contributor

For QA testing on local machine

  • Mock feature flipper
    • src/applications/mhv-landing-page/mocks/api/feature-toggles/index.js:7
  • Mock mhvAccountState data
    • src/applications/mhv-landing-page/mocks/api/user/index.js:67
  • Mock API response
    • src/applications/mhv-landing-page/mocks/api/index.js:20

@wesrowe
Copy link
Contributor Author

wesrowe commented Dec 16, 2024

@kjsuarez, I thought at one point you considered implementing both ACapi alerts in one PR – the original one in this ticket PLUS the "technical" error one in #98360?

I just want to get a handle on where we are. I looked at the PR linked higher up here, only saw one alert screenshot. And the second story is sitting in Next Sprint.

@kjsuarez
Copy link
Contributor

I had considered handling both kinds of errors as a single PR, but considering the size of the PR as it stands I think it would be a good idea to keep these as separate tickets.

@dcloud dcloud moved this from In Progress to Code/PR Review in Cartographers / MHV Home Dec 18, 2024
@mcarterA6
Copy link

Moving this ticket to Sprint 47.

@kjsuarez kjsuarez moved this from Code/PR Review to QA/A11y Review in Cartographers / MHV Home Dec 19, 2024
@allanto-ah
Copy link
Contributor

Environment: Staging

Verified that error codes, 801, 805, 806, 807, generates a specific error code alert on the MHV landing page.

Regression testing was also done to ensure that nothing broke:

  1. Verified that the error code didn't shown for a newly created account
  2. Verified that existing test users was able to login as expected and didn't run into any issues
Image

@allanto-ah
Copy link
Contributor

Environment: Staging

Verified that these alerts appear in GA4

Image

@github-project-automation github-project-automation bot moved this from QA/A11y Review to Done in Cartographers / MHV Home Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cartographers MHV on VAgov team engineering Engineering topics
Projects
Status: Done
Development

No branches or pull requests

5 participants