Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading disabled button variation - development #3460

Open
6 tasks
caw310 opened this issue Oct 29, 2024 · 2 comments · May be fixed by department-of-veterans-affairs/component-library#1446
Open
6 tasks
Assignees
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-button DS Buttons

Comments

@caw310
Copy link
Contributor

caw310 commented Oct 29, 2024

Description

The disabled variation to va-button needs to be update.

  • Only the Loading button for disabled variation.
  • Icon should be standardized so it will not be changeable.
  • Loading should be default text.

Details

Link to Figma: https://www.figma.com/design/afurtw4iqQe6y4gXfNfkkk/VADS-Component-Library?node-id=15460-5337&t=lqYqIx2f8QOr613j-1

Considerations

  • Accessibility: needs to announce statuses for loading and loading complete
  • Consider a media query for reduce motion
  • use autorenew icon

Tasks

  • Update va-button variation to only be used as Loading button
  • Make the loading text the default but allow for changes
  • Use the loading icon and make it not changeable
  • Review update with a designer to get feedback
  • Publish the change

Acceptance Criteria

  • va-button disabled variation is the loading variation only

Estimating

Provide your estimate of 1, 2, 3, 5, 8 or 13
@Andrew565 - 3
@ataker - 3
@harshil1793 - 3
@it-harrison - 3
@jamigibbs - 3
@micahchiang - 3
@powellkerry - 3
@rmessina1010 -
@rsmithadhoc - 3

@caw310 caw310 added DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-button DS Buttons labels Oct 29, 2024
@caw310
Copy link
Contributor Author

caw310 commented Oct 29, 2024

@caw310 caw310 changed the title Update the disabled button variation - development Add loading disabled button variation - development Dec 3, 2024
@Andrew565
Copy link
Contributor

Use the va-icon called "Autorenew", will need to animate it spinning with CSS. DO NOT USE "LOOP" ICON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-button DS Buttons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants