-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update telephone component to allow International phone numbers #3472
Update telephone component to allow International phone numbers #3472
Comments
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rmessina1010 @rsmithadhoc |
@jamigibbs and @caw310 I saw that but that looks like the Telephone pattern for the text input, not the telephone component, which was why I filed this. Apologies if I misunderstood but if this is the same, could you point me to any documentation on how to implement a non-US country code? |
@laflannery Not sure what you were looking at but we did recently do work to accommodate international phone nubmers. |
Thanks @caw310 I had seen that particular prop, however, that's for a 10-digit phone number that is intended to be called outside the US, so it automatically adds a What we need is a true international number, a non-US number that has a different country code. In this case it's for the Manila VA Clinic and the number is +63 (02) 8550 3888. There currently isn't a way to accommodate a country code that isn't |
Bug Report
What happened
The current telephone component has an
international
prop which is slightly misleading because this can only be used for 10-digit, US numbers. If I have a local number for a location that is international (non-US) and therefore not 10-digits and has a different country code than +1, I am unable to use the component because:international
prop)international
prop +1 is added to the visual displayYou can see the issue on the Mental Health number on the Manila VA clinic. This is a local number and it should be +63 (02) 8550 3888.
What I expected to happen
In order to properly add an international number, I expect to:
Reproducing
Steps to reproduce:
Urgency
How urgent is this request? Please select the appropriate option below and/or provide details
Details
While there are a few issues here, the most pressing issue is the incorrect country code and the +1 being automatically added to the
href
as this is stopping the number from being auto dialedThe text was updated successfully, but these errors were encountered: