-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Figma components based on USWDS 3.9.0 update #3524
Comments
@danbrady @babsdenney - This one is ready for review. Updated the spacing on the alert / banner / prefill alert but note that it uses an odd spacing (not based on 8) of 20. Since the autolayout already has 8px of padding I added another 12 to the left side of the container to make the padding match the 20 of USWDS |
Hey @LWWright7, I finally got around to checking this out. This is what I noticed: Alert
Pagination
Thanks all! |
@danbrady @babsdenney The suggested updates in Figma and from the comments above have been made and this is ready to be reviewed again. |
@LWWright7 Are we able to fix the overlapping close button in Alerts? In pagination it looks like the default and active pages are positioned differently: Thanks! |
@danbrady You're totally right about the pagination alignment. This should be fixed now. And I thought I had fixed the slim version overlap with close button initially, but I saw that if one adjusts the size of the box there were still some breakpoints where there was an overlap. So I fudged with it this morning but am still having some issues. I may ping you to ask for some help if I can't figure it out. It's defiantly giving me fits :( |
@LWWright7 Pagination looks good now. Do we know the status of the mobile variations though? They are not currently published, but I'm not sure if they should be? I know we were working with USWDS a bit on them. @babsdenney, do you know the status of these? (I don't want them to get accidentally published if they're not ready.) Regarding the toggleable close button, how do we handle it in the normal (non-slim) Alert? We can probably do it the same way, right? |
@danbrady Good point about the mobile pagination. @babsdenney Please let me know if these mobile versions should be published. @danbrady - I think I got the slim closable version figured out!! :) It took some finagling but it should be working as intended now! |
This ticket is carrying over because of some issues with the pagination component that were not sorted out and approved before the end of the sprint. Alert has been updated and published. |
Description
Updating VADS to USWDS 3.9.0 introduced some minor visual changes to a several components (all variations):
View Chromatic UI Tests build 1760 for visual diffs.
Tasks
Acceptance Criteria
The text was updated successfully, but these errors were encountered: