Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language toggle component - Design #3605

Open
5 tasks
caw310 opened this issue Dec 11, 2024 · 10 comments
Open
5 tasks

Update language toggle component - Design #3605

caw310 opened this issue Dec 11, 2024 · 10 comments
Assignees
Labels
DST-Design Use to designate DS designer work Figma platform-design-system-team

Comments

@caw310
Copy link
Contributor

caw310 commented Dec 11, 2024

Description

During the a11y review, Ryan raised a concern that only having bold text as the visual indicator may not be enough for visually impaired users.
The language toggle design needs updating to make the selected language more prominent. Here are some notes from the discussion between DST designers and Matt.

  • Keep it as inert if you are on current version of the page. Bold, black and underlined.
  • Don’t move or shift to accommodate the bar or icon.
  • If there is a WCAG reason icon is needed, okay with an icon. Follow side nav rules. Refer to USWDS implementation. Pad towards the text. If that doesn’t work, try other things. Go with bolder, thicker underline. As long as not blue.

Details

Dev ticket to make updates to address a11y issues: #3564

Tasks

  • Update the design of the language toggle component to add a bar or icon next to the selected language
  • Review updated designs with DST designers and PO to get feedback
  • Make any necessary changes
  • Post link to Figma design in Language toggle accessibility updates #3564

Acceptance Criteria

  • Language toggle designs have been updated
@LWWright7
Copy link
Contributor

Per yesterday's meeting with @humancompanion-usds the design should utilize the colored bar to indicate the language that is currently "in use" similar to the USWDS side navigation component:
Image

@LWWright7
Copy link
Contributor

@babsdenney @danbrady This is ready for review!

@danbrady
Copy link
Contributor

danbrady commented Dec 12, 2024

@LWWright7 Similar to Barb's comment in Figma, I think we might want to explore a few options. I see you did what we discussed as a potential solution, but the vertical bar looks awkward to me. Not sure if it's because the active bar is shorter than the normal separator one? Or because English has a left bar when active but not when inactive? Or because the text is still blue like it's a link but it's not...?

For reference

Currently published:


Your proposed changes:


Honestly, I would expect it to simply look like this:



Perhaps I'm misunderstanding the issue with this?

@rsmithadhoc Could you help us understand what the accessibility issue is with this approach? Thanks!

CC: @humancompanion-usds

@rsmithadhoc
Copy link
Contributor

@LWWright7 Similar to Barb's comment in Figma, I think we might want to explore a few options. I see you did what we discussed as a potential solution, but the vertical bar looks awkward to me. Not sure if it's because the active bar is shorter than the normal separator one? Or because English has a left bar when active but not when inactive? Or because the text is still blue like it's a link but it's not...?

For reference

Currently published:

### Your proposed changes: Honestly, I would expect it to simply look like this:

Perhaps I'm misunderstanding the issue with this?

@rsmithadhoc Could you help us understand what the accessibility issue is with this approach? Thanks!

CC: @humancompanion-usds

@danbrady I think keeping it a link makes the experience more consistent for all users. I wrote up a comment for breadcrumbs when we looked at that, and I think similar reasoning applies here.

@LWWright7
Copy link
Contributor

@rsmithadhoc are you suggesting something more like this?

Image

@LWWright7
Copy link
Contributor

Several other design considerations mentioned above now in Figma

@rsmithadhoc
Copy link
Contributor

@rsmithadhoc are you suggesting something more like this?

Image

Several other design considerations mentioned above now in Figma

@LWWright7 Yeah, I think keeping the current selection as a link and maintaining the link styling is good. So the option presented here or any of the options in Figma that do that are fine with me. Thanks!

@LWWright7
Copy link
Contributor

@rsmithadhoc The design team met with @humancompanion-usds yesterday to discuss this matter and we took into account your comments in regards to the similarities of breadcrumb. While we understand your position for a11y sake, @danbrady pointed out this WCAG example breadcrumb here:

Image

For the sake of better usability and user experience we are suggesting that the page/language that is active display to the user (or the language that is being displayed on the page) should differ from appearance from the other links that are active. The user may be confused if they see what they think is a link and clicking on it does nothing, so we are suggesting that we follow the example set here by WCAG to make the current page text black in color.

With that being said, we believe that one of these two designs is best suited for the task:
Image

We also wanted to tag @briandeconinck for your input and opinion on the matter at hand.

@LWWright7
Copy link
Contributor

@babsdenney @danbrady This one is ready for review!!

@briandeconinck Would still love to hear your 2 cents on this one! :)

@rsmithadhoc
Copy link
Contributor

@rsmithadhoc The design team met with @humancompanion-usds yesterday to discuss this matter and we took into account your comments in regards to the similarities of breadcrumb. While we understand your position for a11y sake, @danbrady pointed out this WCAG example breadcrumb here:

Image

For the sake of better usability and user experience we are suggesting that the page/language that is active display to the user (or the language that is being displayed on the page) should differ from appearance from the other links that are active. The user may be confused if they see what they think is a link and clicking on it does nothing, so we are suggesting that we follow the example set here by WCAG to make the current page text black in color.

With that being said, we believe that one of these two designs is best suited for the task: Image

We also wanted to tag @briandeconinck for your input and opinion on the matter at hand.

If you feel strongly about that version, we can go with that. It's not a huge deal, so I don't think we need to drag out the discussion any longer.

However, I will point out that the example shared from W3C is a link, it just doesn't look like one.
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-Design Use to designate DS designer work Figma platform-design-system-team
Projects
None yet
Development

No branches or pull requests

5 participants