Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or swap imports for the documentation repo #3621

Open
3 tasks
caw310 opened this issue Dec 16, 2024 · 0 comments
Open
3 tasks

Update or swap imports for the documentation repo #3621

caw310 opened this issue Dec 16, 2024 · 0 comments
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@caw310
Copy link
Contributor

caw310 commented Dec 16, 2024

Description

Now that we are done with formation deprecation, we need to update packages to make sure our style imports are coming from css-library.

Considerations

  • We'll need to update this css-library import
  • The doc site still relies heavily on v1 grid, which we patched directly in vets-website. We'll need to migrate grid first before fully removing formation from the doc site.
  • There's extensive use of scss variables in /assets/stylesheets/ throughout many stylesheets. It's possible there are some being used in here that we don't carry in css-library, such as $font-bold and $font-sans in the _do-dont.scss stylesheet. Instances like this will need to be updated to whatever their equivalents are from the variables we do generate. Running a yarn watch will likely throw variable errors for these once import paths are updated.

Tasks

Acceptance Criteria

  • Import paths have been updated for the doc site so they point to css-library
@caw310 caw310 added platform-design-system-team DST-engineering Issues that require work from Design System Team engineers labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

1 participant