Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Upload - Error message before file selection #3625

Open
2 of 6 tasks
Thrillberg opened this issue Dec 16, 2024 · 4 comments
Open
2 of 6 tasks

Form Upload - Error message before file selection #3625

Thrillberg opened this issue Dec 16, 2024 · 4 comments
Assignees

Comments

@Thrillberg
Copy link

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

When using the file input component in the Form Upload flow, the user clicks "choose from folder" to begin uploading a file. The browser correctly opens a file browser but then a validation kicks in causing an error message to appear in the background.
Image

What I expected to happen

I'd rather the error message only appear if they hit Cancel and do NOT indicate a file to upload. Otherwise, it shouldn't appear at all.

Reproducing

  • Formation version:
  • Device: Macbook
  • Browser: Firefox

Steps to reproduce:

  1. Sign in
  2. Go to https://staging.va.gov/form-upload/21-0779
  3. Go through the form until https://staging.va.gov/form-upload/21-0779/upload
  4. Click on "choose from folder"

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

@Thrillberg Thrillberg added bug Something isn't working platform-design-system-team labels Dec 16, 2024
@caw310
Copy link
Contributor

caw310 commented Dec 16, 2024

@Thrillberg Is this preventing you from properly using the file input component? Or is it a visual issue?

@Thrillberg
Copy link
Author

@caw310 Technically the component is usable without this, but the UX is pretty jarring as it unnecessarily displays an error. As long as the user knows to ignore it, it's only a visual issue. I'd defer to @humancompanion-usds for prioritization/urgency questions though.

@caw310
Copy link
Contributor

caw310 commented Dec 17, 2024

@Thrillberg It sounds as if this is not blocking work in progress since the component is usable. We will discuss and prioritize for a future sprint.

@caw310
Copy link
Contributor

caw310 commented Dec 17, 2024

Hey team! Please add your estimate @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc
Provide your estimate of 1, 2, 3, 5, 8 or 13

@ataker ataker self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants