From 19aa851141411bfc9204bc964480fc833e275f90 Mon Sep 17 00:00:00 2001
From: Jun Tao Luo
Date: Thu, 26 Dec 2024 12:24:07 -0500
Subject: [PATCH 1/2] Update appointment links that open in a new tab
---
.../components/ContactInfoPage.jsx | 2 +-
.../new-appointment/components/ContactInfoPage.jsx | 4 ++--
.../new-appointment/components/NoAddressNote.js | 2 +-
.../TypeOfCarePage/UpdateAddressAlert.jsx | 14 +++++---------
4 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/src/applications/vaos/covid-19-vaccine/components/ContactInfoPage.jsx b/src/applications/vaos/covid-19-vaccine/components/ContactInfoPage.jsx
index b9d58b83c560..4583a56159d7 100644
--- a/src/applications/vaos/covid-19-vaccine/components/ContactInfoPage.jsx
+++ b/src/applications/vaos/covid-19-vaccine/components/ContactInfoPage.jsx
@@ -47,7 +47,7 @@ const uiSchema = {
services?
- Go to your VA profile
+ Go to your VA.gov profile (opens in new tab)
.
diff --git a/src/applications/vaos/new-appointment/components/ContactInfoPage.jsx b/src/applications/vaos/new-appointment/components/ContactInfoPage.jsx
index f28972c9831a..eb40bd672285 100644
--- a/src/applications/vaos/new-appointment/components/ContactInfoPage.jsx
+++ b/src/applications/vaos/new-appointment/components/ContactInfoPage.jsx
@@ -122,7 +122,7 @@ function Description() {
services?
- Go to your VA profile
+ Go to your VA.gov profile (opens in new tab)
.
@@ -245,7 +245,7 @@ export default function ContactInfoPage() {
benefits and services in your VA.gov profile.
- Go to your VA profile
+ Go to your VA.gov profile (opens in new tab)
diff --git a/src/applications/vaos/new-appointment/components/NoAddressNote.js b/src/applications/vaos/new-appointment/components/NoAddressNote.js
index 894822983490..8f16073c1e79 100644
--- a/src/applications/vaos/new-appointment/components/NoAddressNote.js
+++ b/src/applications/vaos/new-appointment/components/NoAddressNote.js
@@ -8,7 +8,7 @@ export default function NoAddressNote() {
your home address to your VA profile.
- Go to your VA.gov profile
+ Go to your VA.gov profile (opens in new tab)
);
diff --git a/src/applications/vaos/new-appointment/components/TypeOfCarePage/UpdateAddressAlert.jsx b/src/applications/vaos/new-appointment/components/TypeOfCarePage/UpdateAddressAlert.jsx
index 6cda3d0af94d..e3407b7b3ca5 100644
--- a/src/applications/vaos/new-appointment/components/TypeOfCarePage/UpdateAddressAlert.jsx
+++ b/src/applications/vaos/new-appointment/components/TypeOfCarePage/UpdateAddressAlert.jsx
@@ -6,10 +6,6 @@ import InfoAlert from '../../../components/InfoAlert';
export default function UpdateAddressAlert({ onClickUpdateAddress }) {
const headline =
'To use some of the tool’s features, you need a home address on file';
- const style = {
- width: 'fit-content',
- webkitWidth: 'fit-content',
- };
return (
To update your address, go to your VA.gov profile. Please allow some
- time for your address update to process through our system.
+ time for your address update to process through our system.
+
onClickUpdateAddress(headline)}
+ renderAriaLabel={false}
>
- Update your address
+ Go to your VA.gov profile (opens in new tab)
From 7d9eacab15b252404a0c0efe65d1d9855940ec92 Mon Sep 17 00:00:00 2001
From: Jun Tao Luo
Date: Thu, 26 Dec 2024 12:58:23 -0500
Subject: [PATCH 2/2] Fix unit test
---
.../components/TypeOfCarePage/index.unit.spec.js | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/applications/vaos/new-appointment/components/TypeOfCarePage/index.unit.spec.js b/src/applications/vaos/new-appointment/components/TypeOfCarePage/index.unit.spec.js
index 74bd6155bda8..0002e96d374e 100644
--- a/src/applications/vaos/new-appointment/components/TypeOfCarePage/index.unit.spec.js
+++ b/src/applications/vaos/new-appointment/components/TypeOfCarePage/index.unit.spec.js
@@ -299,7 +299,9 @@ describe('VAOS Page: TypeOfCarePage', () => {
'vaos-update-address-alert-displayed',
),
);
- fireEvent.click(screen.getByText('Update your address'));
+ fireEvent.click(
+ screen.getByText('Go to your VA.gov profile (opens in new tab)'),
+ );
await waitFor(
() =>
expect(
@@ -355,7 +357,9 @@ describe('VAOS Page: TypeOfCarePage', () => {
/To use some of the tool’s features, you need a home address on file/i,
),
).to.exist;
- fireEvent.click(screen.getByText('Update your address'));
+ fireEvent.click(
+ screen.getByText('Go to your VA.gov profile (opens in new tab)'),
+ );
await waitFor(
() =>
expect(