Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot not parsing sub-repositories on full package imports in, missing known vulnerabilities. #8549

Open
1 task done
bucketcat opened this issue Dec 6, 2023 · 0 comments
Labels
T: bug 🐞 Something isn't working

Comments

@bucketcat
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

gomod

Package manager version

No response

Language version

Golang 1.19

Manifest location and content before the Dependabot update

No response

dependabot.yml content

https://gist.github.com/magnetikonline/6f215db058e327905bce66c37f92426c#file-dependabot-yml

Updated dependency

No response

What you expected to see, versus what you actually saw

Two known vulnerabilities in dependencies are not detected if an entire package is imported in go.mod. Specific examples are specified in this issue.
gcla/termshark#157

Currently, all of ´golang.org/x/` is imported, and the sub-packages are used.

By specifying the specific sub-packages in go.mod such as 'golang.org/x/net', Dependabot is able to instantly pick up on them. I don't know if this is a problem with a regex pattern and wildcard imports or if it's due to how Go handles packages through go.mod and go.sum.

In the reference repo, Dependabot has not detected them. But if you create a fork, set up Dependabot, and explicitly specify golang.org/x/net & golang.org/x/text in go.mod, it will pick up on them instantly.

Maybe this is because Dependabot is looking for "*" for wildcard imports, which seems to not be needed in Go?"

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@bucketcat bucketcat added the T: bug 🐞 Something isn't working label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant