-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply with source if users ask for it #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, I also had to move the actual posting of a random quote out of the "root" of the bot, otherwise, it would post a random quote every time it tries to reply to users (every 10 minutes). See commit |
Since there is no CI yet (see #4) I will merge this now and see how it goes in the wild.
|
🍀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #1.
I introduced a new script which can be executed with
yarn reply
. The bot will search twitter for unanswered replies which contain the word "source". If there are any, the bot will perform a lookup of the quote source and post a reply in the following form:Added some tests for the lookup and some other things. There could be more thorough testing, maybe I'll get around to write tests for every quote.
I plan to set up a job to execute the
reply
script every 10 minutes.