Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGS Group Catalog VAC Review (DR1) #22

Open
4 tasks done
dylanagreen opened this issue Dec 30, 2024 · 4 comments
Open
4 tasks done

BGS Group Catalog VAC Review (DR1) #22

dylanagreen opened this issue Dec 30, 2024 · 4 comments
Assignees
Labels
vac review Issues pertaining to VAC reviews

Comments

@dylanagreen
Copy link

dylanagreen commented Dec 30, 2024

Contact Person: Ian Williams
1 catalog file (fits), 1 README

Initial Checks:

  • Includes README
  • Columns in ALLCAPS
  • Extension names in ALLCAPS
  • Files include units

Initial Notes:

  • Can you please add an extension name to the fits header so that it can be accessed by name and not just index?
  • Thanks for including units in your VAC file!
  • I'm not seeing anything else jumping out at me at this time, thanks
@dylanagreen dylanagreen self-assigned this Dec 30, 2024
@ianw89
Copy link

ianw89 commented Jan 2, 2025

I believe I have now addressed this and updated the FITS file on NERSC, @dylanagreen

@dylanagreen
Copy link
Author

Thanks @ianw89, this is looking good and I think we can move it to final review @weaverba137

@weaverba137
Copy link
Member

We need to finalize the "stub" catalog name for this one, after which I think it is OK to move to staging.

@dylanagreen
Copy link
Author

dylanagreen commented Jan 17, 2025

@ianw89 Do you have a preferred stubname for this VAC? The stubname will be used for the README file as well as the on-disk location for the vac (e.g. /dr1/stubname/v1.0/). If not I suggest some variation of bgs-groups.

@dylanagreen dylanagreen added the vac review Issues pertaining to VAC reviews label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vac review Issues pertaining to VAC reviews
Projects
None yet
Development

No branches or pull requests

3 participants