Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review dr1/target/ -- does anything else need to be added? #34

Closed
weaverba137 opened this issue Jan 7, 2025 · 6 comments
Closed

Review dr1/target/ -- does anything else need to be added? #34

weaverba137 opened this issue Jan 7, 2025 · 6 comments
Assignees

Comments

@weaverba137
Copy link
Member

No description provided.

@sbailey
Copy link
Contributor

sbailey commented Jan 7, 2025

I'm going to pass this to @geordie666 to review if there are any additional target catalogs that need to be added in support of dr1 (iron).

Specific case: $CFS/desi/public/edr/target/masks exists but $CFS/desi/public/dr1/target/masks does not.

@geordie666
Copy link

I think we could link the $CFS/desi/public/edr/target/masks directory to $CFS/desi/public/dr1/target/masks if we chose to, yes. These masks are used in support of the production of the targets but the masks haven't changed since the edr release, so it might not be crucial to include them. Anyway, bottom line:

  • I'd make a symbolic link to include $CFS/desi/public/dr1/target/masks.

The only other thing I see that is potentially missing is the $CFS/desi/target/catalogs/dr9/2.5.0 directory and the supporting $CFS/desi/target/secondary/main3/ directory of secondary targets. It looks like I made that on September 7 2022, though, which I guess is after the cutoff date for DR1. OTOH, it looks like there are plenty of directories in edr that were created after the June 10, 2021 cutoff date for the EDR:

https://data.desi.lbl.gov/public/edr/target/catalogs/dr9/

So, I'm not sure what the policy is on that front.

In any case, we could, also, make symbolic links:

  • From $CFS/desi/target/catalogs/dr9/2.5.0 to $CFS/desi/public/dr1/target/catalogs/dr9
  • From $CFS/desi/target/secondary/main3 to $CFS/desi/public/dr1/target/secondary

But, as I'm not sure what the policy is on cut-off date, I'm not sure if we should. We should either make both links or neither.

@weaverba137
Copy link
Member Author

I agree that we can create a link to point to edr/target/masks.

@sbailey, what is your feeling about 2.5.0/main3? Perhaps that should actually be in DR2?

@weaverba137
Copy link
Member Author

PS, as a reminder, edr/target/catalogs and edr/target/secondary, are themselves links to the ets release.

@weaverba137
Copy link
Member Author

@sbailey pinging you for comment.

@sbailey sbailey self-assigned this Feb 10, 2025
@weaverba137
Copy link
Member Author

Based on discussions with @sbailey, we can close this as "nothing further needed."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants