-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New petal-alignments.yaml needed #188
Comments
Note that simply replacing The minimal change is probably to update the API by adding an optional date or exposure ID parameter to the |
We need time dependent configurations for desimeter. One approach would be to list the calibration files (petal transformation, but also fiducials and positioners IDs in the metrology table, new metrology table patch if some fiducials have moved, new distortion coefficients for the transforms) would be listed in a configuration yaml file, with several configurations depending on the date of the observations, like we do for the spectroscopic pipeline (see https://desi.lbl.gov/trac/wiki/Pipeline/SpectroCalib and the calibration finder code https://github.com/desihub/desispec/blob/master/py/desispec/calibfinder.py) |
For reference, the before/after alignments are displayed in this interactive notebook. |
I just created a new branch where the yaml file is updated for the post-shutdown alignment. This is not the way forward (so should not be merged), but at least allows @deisenstein to continue analyzing the new calibration data via:
More details: the new branch has separate |
I just rebased the
|
New focal plane metrology (petal alignments) provided by Steve is needed for offline FP calibration analysis.
json copied to text below with updated information:
{
"type": "group",
"name": "focal_plane_metrology",
"version": 200,
"elements": [
}
},
}
},
}
},
}
},
}
},
}
},
}
},
}
},
}
},
}
}
}
The text was updated successfully, but these errors were encountered: