Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new output from fit_trace_shifts. #2426

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

sybenzvi
Copy link
Contributor

The function fit_trace_shifts now outputs three data structures instead of a single XYTraceSet instance when shift_psf is set to True. This fix will unbreak qproc for processing of science and calibration exposures (see nightwatch#444).

@sybenzvi sybenzvi requested a review from sbailey December 11, 2024 14:41
@coveralls
Copy link

Coverage Status

coverage: 39.455% (+0.01%) from 39.443%
when pulling d2fd516 on fix-trace-fit-output
into efec8c6 on main.

@sbailey
Copy link
Contributor

sbailey commented Dec 11, 2024

Apologies that we broke that in PR #2411! Merging now and I'll update desispec at NERSC for tonight.

@sbailey sbailey merged commit 3c6b692 into main Dec 11, 2024
26 checks passed
@sbailey sbailey deleted the fix-trace-fit-output branch December 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants